| Summary: | ASTERISK-04573: [patch] Allow restart char for ast_control_streamfile | ||
| Reporter: | Clod Patry (junky) | Labels: | |
| Date Opened: | 2005-07-12 23:17:40 | Date Closed: | 2008-01-15 15:44:42.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) control_restart_rev1.txt | |
| Description: | In app_controlplayback.c , we have all these arguments: ControlPlayback(filename[|skipms[|ffchar[|rewchar[|stopchar[|pausechar]]]]]) The only argument missing is a key to restart the whole stream, whatever we are in streaming of the current file. So that patch add that possibility. I had to modify app_voicemail.c, cause i've changed the core function (ast_control_streamfile), and i've put 2 as the reset character, if you prefer any other value, feel free to change it. Plus, i had to change the prototype too, i've added to resetchar at the penultimate position (2nd last), just to be consistent, when grouping all the const char together, then the skip time. | ||
| Comments: | By: Clod Patry (junky) 2005-07-18 19:20:05 Can ive some feedback on this one please? By: Clod Patry (junky) 2005-08-19 00:09:17 Quick review someone? By: Mark Spencer (markster) 2005-08-19 01:54:40 looks great to me... Probably post 1.2 though? I'd like kevin's input. By: Kevin P. Fleming (kpfleming) 2005-08-22 15:05:07 Committed to CVS HEAD, although I reworked app_controlplayback.c to take into account all the items on the Asterisk 1.2 janitor list. Thanks! By: Digium Subversion (svnbot) 2008-01-15 15:44:42.000-0600 Repository: asterisk Revision: 6352 U trunk/app.c U trunk/apps/app_controlplayback.c U trunk/apps/app_voicemail.c U trunk/include/asterisk/app.h ------------------------------------------------------------------------ r6352 | kpfleming | 2008-01-15 15:44:42 -0600 (Tue, 15 Jan 2008) | 3 lines add 'restart' character to ast_control_playback function and ControlPlayback() application (issue ASTERISK-4573) rework app_controlplayback.c to take into account all Asterisk 1.2 coding style requirements ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6352 | ||