[Home]

Summary:ASTERISK-04564: channel_find_locked( NULL, mysearchstring, 0) works not as proposed
Reporter:Frank Sautter (xylome)Labels:
Date Opened:2005-07-12 02:27:46Date Closed:2008-01-15 15:41:08.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:using ast_get_channel_by_name_locked(mysearchstring,) i found out, that channel_find_locked( NULL, mysearchstring, 0) does not work as proposed.
when there is no match for the searchstring, the function will return the last entry of the linked list and not NULL as it should.
an easy way to reproduce this is by typing 'show channel gargelkarg' on the cli _when there is another active call_. it should return 'gargelkarg is not a known channel' but instead shows the last entry in the channel list (of course, it returns NULL when the channel list is empty).

i think this problem is for people with deep insight into all asterisk functionality, as i don't know if some code is relying on this malfunction.
Comments:By: Kevin P. Fleming (kpfleming) 2005-07-12 11:52:32

Fixed in CVS HEAD, thanks for the report (it was a stupid logic error).

By: Digium Subversion (svnbot) 2008-01-15 15:41:08.000-0600

Repository: asterisk
Revision: 6110

U   trunk/channel.c

------------------------------------------------------------------------
r6110 | kpfleming | 2008-01-15 15:41:08 -0600 (Tue, 15 Jan 2008) | 2 lines

fix logic error in searching for channel by name (bug ASTERISK-4564)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6110