[Home]

Summary:ASTERISK-04562: [patch] use of uninitialized variable
Reporter:Luigi Rizzo (rizzo)Labels:
Date Opened:2005-07-12 00:42:48Date Closed:2008-01-15 15:41:07.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) vm1.diff
Description:forward_message() uses a potentially uninitialized variable, receiver.
This patch initializes it.
(discovered by gcc -Wall -Wuninitialized -Werror)
Comments:By: Tilghman Lesher (tilghman) 2005-07-12 09:54:12

Nope, completely unnecessary.  Read the code, please.  receiver is ALWAYS initialized before it is used.
By: Russell Bryant (russell) 2005-07-12 11:16:07

Corydon is correct in that the logic in that function makes it so receiver will never be used without being initialized.  However, there is no way for the compiler to know that.  It's not worth leaving the warning around.
By: Digium Subversion (svnbot) 2008-01-15 15:41:06.000-0600

Repository: asterisk
Revision: 6107

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r6107 | russell | 2008-01-15 15:41:05 -0600 (Tue, 15 Jan 2008) | 2 lines

get rid of compiler warning (bug ASTERISK-4562)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6107
By: Digium Subversion (svnbot) 2008-01-15 15:41:07.000-0600

Repository: asterisk
Revision: 6108

U   trunk/include/asterisk/strings.h

------------------------------------------------------------------------
r6108 | russell | 2008-01-15 15:41:06 -0600 (Tue, 15 Jan 2008) | 2 lines

convert ast_copy_string to use AST_INLINE_API macro (bug ASTERISK-4562)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6108
By: Digium Subversion (svnbot) 2008-01-15 15:41:07.000-0600

Repository: asterisk
Revision: 6109

U   branches/v1-0/apps/app_voicemail.c

------------------------------------------------------------------------
r6109 | russell | 2008-01-15 15:41:07 -0600 (Tue, 15 Jan 2008) | 2 lines

fix compiler warning (bug ASTERISK-4562)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6109