| Summary: | ASTERISK-04548: Cygwin Patches (res dir) | ||
| Reporter: | Michael Jerris (mikej) | Labels: | |
| Date Opened: | 2005-07-10 14:59:04 | Date Closed: | 2005-07-11 23:15:42 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) CygwinResPatch.txt | |
| Description: | Patches for cygwin for the res dir. Derived from asteriskwin32. both he and I have a disclaimer. | ||
| Comments: | By: Tilghman Lesher (tilghman) 2005-07-10 23:24:07 1) I note you have #ifdef __CYGWIN__ in some places and #ifndef __CYGWIN__ #else in others. Why not use #ifdef __CYGWIN__ everywhere? 2) In one place, near original line 1943, you have a declaration that is NOT at the beginning of a code block, which is not good code practice. Declarations should always occur at the beginning of a code block, not in the middle. By: Michael Jerris (mikej) 2005-07-11 07:45:50 I will create updates for this soon. | ||