Summary:ASTERISK-04541: [patch] Added the ability to 'escape' durning recording and review message.
Reporter:Paul Belanger (pabelanger)Labels:
Date Opened:2005-07-08 16:47:26Date Closed:2011-06-07 14:02:36
Versions:Frequency of
Environment:Attachments:( 0) app_voicemail-v3.txt
Description:Currently you are able to 'escape' only durning the initial voicemail greeting to the 'a' context by pressing '*'.  This patch will also now allow you to escape durning the recording and review message, but also pressing '*'


Review greeting may / will have to be updated.

Disclaimer will be faxed in tonight or tomorrow.
Comments:By: Michael Jerris (mikej) 2005-07-08 16:53:47

if you do a fresh checkout, apply the two patches, then do a cvs diff -u you can create a single patch.  Please re-upload a single patch w/ .txt extension for easier review.  Thanks.

By: Paul Belanger (pabelanger) 2005-07-08 18:46:58

MikeJ: Sorry about this.  Redone per your request.

By: Paul Belanger (pabelanger) 2005-07-08 18:50:15

Doh! Version 2 will fix a typo.  Should work now.

By: Paul Belanger (pabelanger) 2005-07-08 19:21:59

Ugh!  Please excuse my screw up.  This is what I get for rushing a patch out.  I will upload version 3, when I get home.

By: Paul Belanger (pabelanger) 2005-07-08 20:31:21

As promised v3.

By: Paul Belanger (pabelanger) 2005-07-11 09:41:36

Disclaimer submitted 07/11/2005.

By: Kevin P. Fleming (kpfleming) 2005-07-12 15:24:54

The disclaimer has been received.

Your patch changes the behavior of ast_play_and_record to always stop recording when '*' is pressed, but this affects more applications than just app_voicemail. This will probably have to be a configurable option, or isolated only to app_voicemail in some way.

Also, I have not applied the patch and followed the logic flow, but I hope there is a better way to handle receiving '*' than by jumping back to the top of a loop...

By: Paul Belanger (pabelanger) 2005-07-12 21:11:19

kpfleming: Correct, I did modify ast_play_and_record.  I figured this would have some side-effects.  I will revert my changes and find some way to work it out.

As for the goto code for '*', I simply followed has the '0' was handled ;)

By: Michael Jerris (mikej) 2005-07-25 22:39:44

suspended pending updates.  Reopen when you have upadates and are ready to proceeed.