Summary:ASTERISK-04534: [patch] correct plural 's' for serveral CLI outputs
Reporter:Frank Sautter (xylome)Labels:
Date Opened:2005-07-07 07:15:45Date Closed:2008-01-15 15:40:11.000-0600
Versions:Frequency of
Environment:Attachments:( 0) plural-s.20050607.patch.txt
Description:don't know if anybody else bothers?
this is a trivial patch to correct serveral plural 's' outputs on the CLI when in verbose mode.
currently often (s) is used in strings when plural or singular of a noun is needed even when it's easy for the software to determine it's own output.
Comments:By: Clod Patry (junky) 2005-07-07 07:43:07

I refuse it, cause i think you forget the 0 case.
You made a condition for foo != 1, which is false, the right condition is foo > 1.

By: Frank Sautter (xylome) 2005-07-07 08:02:12

no, it's perfectly ok!

it should be
0 calls
1 call
2 calls
15 calls
and that is how it works

By: Clod Patry (junky) 2005-07-07 14:32:34

Sorry, in french, 0 is not plural, i've learn 0 is plural in english.

By: Kevin P. Fleming (kpfleming) 2005-07-07 18:23:54

Committed to CVS HEAD, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:40:11.000-0600

Repository: asterisk
Revision: 6047

U   trunk/apps/app_groupcount.c
U   trunk/apps/app_read.c
U   trunk/apps/app_realtime.c
U   trunk/cdr.c
U   trunk/channels/chan_iax2.c
U   trunk/cli.c
U   trunk/loader.c
U   trunk/pbx/pbx_spool.c
U   trunk/res/res_features.c

r6047 | kpfleming | 2008-01-15 15:40:10 -0600 (Tue, 15 Jan 2008) | 2 lines

make CLI output use singular/plural when appropriate (bug ASTERISK-4534)