Summary:	ASTERISK-04512: [patch] 'send text' CLI command terminates sent text with space instead of newline
Reporter:	Sarah Nordstrom (sarahemm)	Labels:
Date Opened:	2005-07-02 13:55:37	Date Closed:	2008-01-15 15:44:07.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) sendtext-fixterm-20050702-sn-0.diff ( 1) sendtext-fixterm-20050716-sn-1.diff
Description:	The 'send text' CLI command used with chan_oss and chan_alsa terminates any text sent with a space, instead of a newline which would make more sense.
Comments:	By: Kevin P. Fleming (kpfleming) 2005-07-05 15:46:25 This patch actually changes the behavior. As it stands right now, multiple arguments to the command are concatenated with spaces, but your patch would put newlines in between them. I think a better solution would be to use spaces in between arguments, but put a final newline on the string before sending it. By: Sarah Nordstrom (sarahemm) 2005-07-05 16:46:37 I obviously wasn't thinking when i put that patch together.  The behavior totally isn't right, what kpfleming said is how it was supposed to work.  I'll get a new patch out this week, hopefully today. By: Michael Jerris (mikej) 2005-07-12 17:50:04 Suspended due to no response... Open this one back up when the patche is ready.  Thanks! By: Michael Jerris (mikej) 2005-07-12 18:16:40 just kidding. By: Sarah Nordstrom (sarahemm) 2005-07-16 01:22:50 Uploaded patch sendtext-fixterm-20050716-sn-1.diff which obsoletes patch  sendtext-fixterm-20050716-sn-0.diff.  This new patch fixes the issue with patch revision 0 that was causing a newline between each word of the argument, and only adds a newline at the very end of the string. By: Mark Spencer (markster) 2005-08-05 17:39:58 Fixed in CVS head.  Thanks By: Russell Bryant (russell) 2005-08-08 14:12:04 fixed in 1.0 as well By: Digium Subversion (svnbot) 2008-01-15 15:43:51.000-0600 Repository: asterisk Revision: 6291 U   trunk/apps/app_authenticate.c U   trunk/channels/chan_alsa.c U   trunk/channels/chan_oss.c ------------------------------------------------------------------------ r6291 | markster | 2008-01-15 15:43:51 -0600 (Tue, 15 Jan 2008) | 2 lines Fix newline issue (bug ASTERISK-4512) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6291 By: Digium Subversion (svnbot) 2008-01-15 15:44:07.000-0600 Repository: asterisk Revision: 6310 U   branches/v1-0/channels/chan_alsa.c U   branches/v1-0/channels/chan_oss.c ------------------------------------------------------------------------ r6310 | russell | 2008-01-15 15:44:07 -0600 (Tue, 15 Jan 2008) | 2 lines terminate 'send text' with a newline (bug ASTERISK-4512) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6310