| Summary: | ASTERISK-04461: Patch from #4447 breaks auth with broadvoice | ||
| Reporter: | chrisy (chrisy) | Labels: | |
| Date Opened: | 2005-06-22 12:55:50 | Date Closed: | 2008-01-15 15:39:04.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Interoperability |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Broadvoices' SIP system presents the authentication digest with the keyword "DIGEST" in the WWW-Authenticate header. The patch in bug 4447 requires this keyword appear with the mixed-case form of "Digest". The line if (strstr(tmp, "Digest ") != tmp) { in function reply_digest() needs to be more accomodating, case insensitive perhaps. ****** ADDITIONAL INFORMATION ****** After an upgrade to the latest HEAD yesterday, registration and calls via Broadvoice were failing with an authentication problem and the report of "no Digest". This problem was not apparent prior to the upgrade. A quick "sip debug peer broadvoice" showed the all-caps "DIGEST" that BV was sending, and a hunt in the code showed that it wants "Digest" and nothing else. | ||
| Comments: | By: Andrew Lindh (andrew) 2005-06-22 14:16:42 ast_strcasestr should work there (channels/chan_sip.c line 7929). I don't know if it violates the SIP spec... By: Kevin P. Fleming (kpfleming) 2005-06-22 15:10:51 Fix committed to CVS HEAD... yes, this is non-compliant behavior (RFC 2617 specifies 'Digest'), but we'll accept it anyway. By: Digium Subversion (svnbot) 2008-01-15 15:39:04.000-0600 Repository: asterisk Revision: 5970 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r5970 | kpfleming | 2008-01-15 15:39:04 -0600 (Tue, 15 Jan 2008) | 2 lines make SIP registration accept RFC non-compliant Digest headers (bug ASTERISK-4461) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5970 | ||