[Home]

Summary:ASTERISK-04459: Calls completed and service level % figures are wrong
Reporter:jmls (jmls)Labels:
Date Opened:2005-06-22 10:20:45Date Closed:2008-01-15 15:43:58.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_queue.c-brokencounter.patch
Description:When performing a "show queue xxx" the "Calls Completed" and "Service Level %" figures are wrong.

The callscompleted field is incremented in update_status of app_queue.c: This can be called several times during the placement of a call to an agent (if the agent's extension is "busy" for example)

I don't think that the line

q->callscompleted++;

should be in update_status


****** ADDITIONAL INFORMATION ******

disclaimer on file
patch attached
Comments:By: jmls (jmls) 2005-06-22 10:23:19

debugging that was carried out:

Before the patch

#############
startup
#############

foxtrot*CLI> show queue group1
group1       has 0 calls (max unlimited) in 'ringall' strategy (0s holdtime), W:0, C:0, A:0, SL:0.0% within 9s
  Members:
     SIP/701 has taken no calls yet
     SIP/702 has taken no calls yet
  No Callers

foxtrot*CLI>

#############
after 1 call (note the C:2, but SIP/701 has taken only one call)
#############

foxtrot*CLI> show queue group1
group1       has 0 calls (max unlimited) in 'ringall' strategy (1s holdtime), W:0, C:2, A:0, SL:50.0% within 9s
  Members:
     SIP/701 has taken 1 calls (last was 3 secs ago)
     SIP/702 has taken no calls yet
  No Callers
foxtrot*CLI>

#############
after 2 calls (note the C:4, but SIP/701 and SIP/702 have taken only one call each)
#############

foxtrot*CLI> show queue group1
group1       has 0 calls (max unlimited) in 'ringall' strategy (2s holdtime), W:0, C:4, A:0, SL:50.0% within 9s
  Members:
     SIP/701 has taken 1 calls (last was 45 secs ago)
     SIP/702 has taken 1 calls (last was 8 secs ago)
  No Callers

foxtrot*CLI>

#############
after patch
#############

foxtrot*CLI> show queue group1
group1       has 0 calls (max unlimited) in 'ringall' strategy (0s holdtime), W:0, C:0, A:0, SL:0.0% within 9s
  Members:
     SIP/701 has taken no calls yet
     SIP/702 has taken no calls yet
  No Callers

foxtrot*CLI>

#############
after 1 call
#############

foxtrot*CLI> show queue group1
group1       has 0 calls (max unlimited) in 'ringall' strategy (1s holdtime), W:0, C:1, A:0, SL:100.0% within 9s
  Members:
     SIP/701 has taken 1 calls (last was 11 secs ago)
     SIP/702 has taken no calls yet
  No Callers

foxtrot*CLI>

#############
after 2 calls
#############


foxtrot*CLI> show queue group1
group1       has 0 calls (max unlimited) in 'ringall' strategy (2s holdtime), W:0, C:2, A:0, SL:100.0% within 9s
  Members:
     SIP/701 has taken 1 calls (last was 46 secs ago)
     SIP/702 has taken 1 calls (last was 11 secs ago)
  No Callers
foxtrot*CLI>
By: jmls (jmls) 2005-06-22 10:24:59

hey, do I get karma this time ? I didn't for ASTERISK-4436 :(

Or have I lost all my karma for asking ?
By: jmls (jmls) 2005-06-22 10:36:27

I think that this bug was introduced in v1.92, when update_status was added to the code.
By: jmls (jmls) 2005-06-23 16:31:47

we've been running today with the patch installed - all queues now report the correct number of connected calls.

However, the service level is still wrong:

pbx*CLI> show queue q1
q1       has 0 calls (max unlimited) in 'rrmemory' strategy (10s holdtime), W:0, C:49, A:27, SL:112.2% within 60s

pbx*CLI> show queue q2
q2         has 0 calls (max unlimited) in 'rrmemory' strategy (8s holdtime), W:0, C:182, A:2, SL:100.5% within 60s

pbx*CLI> show queue group1
group1       has 0 calls (max unlimited) in 'ringall' strategy (2s holdtime), W:0, C:37, A:0, SL:100.0% within 9s
 
if there are no abandoned calls, the sl is correct.

I'll look further into this - or should I raise another issue ?
By: Clod Patry (junky) 2005-06-23 22:03:49

Just gave you +1 for ASTERISK-4436.
Maybe you didnt get it, cause it wasn't  exactly which has been applied, but like you almost find the trouble, i'm giving it anyways.
Thanks.
By: jmls (jmls) 2005-07-05 03:26:59

any chance of this getting into cvs - It's not nice having to make sure that the correct patches are applied in the right order when building a new machine :)

(Once of my techies didn't get all the documentation and forgot to apply this patch!)
By: Kevin P. Fleming (kpfleming) 2005-07-07 19:21:16

Committed to CVS HEAD, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:40:16.000-0600

Repository: asterisk
Revision: 6053

U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r6053 | kpfleming | 2008-01-15 15:40:16 -0600 (Tue, 15 Jan 2008) | 2 lines

ensure that "completed calls" counter is updated properly (bug ASTERISK-4459)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6053
By: Digium Subversion (svnbot) 2008-01-15 15:43:58.000-0600

Repository: asterisk
Revision: 6299

U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r6299 | markster | 2008-01-15 15:43:57 -0600 (Tue, 15 Jan 2008) | 2 lines

Don't record all calls as abandoned (bug ASTERISK-4459) (fixes damage inadvertently added by bug ASTERISK-4524)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6299