[Home]

Summary:ASTERISK-04437: [patch] fix for channel.c timelimit bug
Reporter:paradise (paradise)Labels:
Date Opened:2005-06-17 20:06:28Date Closed:2008-01-15 15:38:33.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) channel.c.timelimit-fix-v4.txt
Description:as described in bug# 4535.
i've found that call timelimit is broken in channel.c from version 1.183 and will dominate the audio path to itself after playing 1st warning till the end of call.
Comments:By: Michael Jerris (mikej) 2005-06-17 20:13:26

Can you please clean up the formatting of the changes (see bug guidelines and coding guidelines).  Good work.
By: paradise (paradise) 2005-06-17 20:29:03

just saw a blank!
btw, new fix added ;-)
By: Michael Jerris (mikej) 2005-06-17 20:48:37

Also, the indenting should be tabs, not spaces..
By: paradise (paradise) 2005-06-17 20:55:08

done.
By: Michael Jerris (mikej) 2005-06-17 21:03:30

mark-  Can you please review this.  It is a fix for somthing broken from the make bridging more efficient commit you made.  
By: paradise (paradise) 2005-06-17 21:14:02

please use v4 patch.
it's a more accurate fix for timelimit functionality.
thanks!


By: Mark Spencer (markster) 2005-06-18 11:52:30

Where is this "50" coming from?
By: paradise (paradise) 2005-06-18 12:52:11

the condition which is added to ast_generic_bridge() has come from ast_channel_bridge() line 3033+ :

               if (config->warning_freq == 0) {
                   playit = 1;
                   first_time=0;
                   playitagain=0;
               } else if (first_time) {
                   playit = 1;
                   first_time=0;
               } else {
                   if ((time_left_ms % config->warning_freq) <= 50) {
                       playit = 1;
                   }
               }
By: Mark Spencer (markster) 2005-06-18 13:16:57

Fixed in CVS head.  Isn't there someone else with a similar issue in the bug tracker?
By: Michael Jerris (mikej) 2005-06-20 23:16:22

Not an issue in 1.0.
By: Digium Subversion (svnbot) 2008-01-15 15:38:33.000-0600

Repository: asterisk
Revision: 5936

U   trunk/channel.c

------------------------------------------------------------------------
r5936 | markster | 2008-01-15 15:38:33 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix timelimit bug (bug ASTERISK-4437)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5936