[Home]

Summary:ASTERISK-04424: [patch] add version files to pbx_ael.c
Reporter:Clod Patry (junky)Labels:
Date Opened:2005-06-16 21:40:52Date Closed:2008-01-15 15:38:21.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ael_version.txt
Description:With latest addition from Mark, there was no version file for new AEL.

so we couldn't get the version number for this specific file.

with this patch:
debian*CLI> show version files pbx_ael.c
File                      Revision
----                      --------
pbx_ael.c                 Revision: 1.1
debian*CLI>


When commiting, i've a question, the:
ASTERISK_FILE_VERSION(__FILE__, "$Revision: 1.1 $")     line
will be updated automatiquely right?


And
debian*CLI> show modules like ael
Module                         Description                              Use Count
pbx_ael.so                     Asterisk Extension Logic Compiler        0
1 modules loaded


it shouldn't be Asterisk Extension Language Compiler instead of Logic?



****** ADDITIONAL INFORMATION ******

Really great job Mark on AEL, congrats.
Comments:By: Clod Patry (junky) 2005-06-16 21:43:44

And if i've:
     1 context test_sip {
     2         1234 => {
     3                 Playback(tt-monkeys);
     4                 Playback(digits/12);
     5         }
     6         8000 => {
     7                 NoOp(one);
     8                 NoOp(two);
     9                 NoOp(three);
    10         };
    11         1 => {
    12                 for (x=0; ${x} < 3; x=${x} + 1) {
    13                         Verbose(x is ${x} !);
    14                 };
    15         };
    16         2 => {
    17                 y=10;
    18                 while (${y} >= 0) {
    19                         Verbose(y is ${y} !);
    20                         y=${y}-1;
    21                 };
    22         };
    23
    24         _5XXX => NoOp(it's a pattern!);
    25 };

(see the missing ; on line 5)
when im reloading, im getting:
Jun 16 22:27:58 WARNING[29122]: pbx_ael.c:128 __grab_token: Syntax error at line 25 of 'extensions.ael', too many closing braces!

That couldn't be clearer that's a problem with ; ? or at least talking about line 5 ,or 6?
By: Brian West (bkw918) 2005-06-16 23:07:25

I can't even get AEL to work at all on my machine.. it complains and just doesn't work.. i'll try again.
By: Clod Patry (junky) 2005-06-17 06:25:52

what's wrong? which errors? compiling errors ? running errors?
By: Mark Spencer (markster) 2005-06-17 08:52:10

Fixed, congrats on the first AEL patch!
By: Digium Subversion (svnbot) 2008-01-15 15:38:21.000-0600

Repository: asterisk
Revision: 5922

U   trunk/pbx/pbx_ael.c

------------------------------------------------------------------------
r5922 | markster | 2008-01-15 15:38:21 -0600 (Tue, 15 Jan 2008) | 2 lines

AEL minor fixes (bug ASTERISK-4424)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5922