Summary:ASTERISK-04395: [patch] Optional exit context and extension matching for app_background
Reporter:Michael Jerris (mikej)Labels:
Date Opened:2005-06-10 22:04:25Date Closed:2008-01-15 15:40:52.000-0600
Versions:Frequency of
Environment:Attachments:( 0) 4511rev4.patch.txt
( 1) backgroundoptionaldigits.patch.txt
Description:added option for a list of digits that app_background will break on.
Comments:By: Michael Jerris (mikej) 2005-06-10 22:05:26

Totally untested.  Somone please give this a try and make sure it does not make anything really bad happen please.

By: Michael Jerris (mikej) 2005-06-12 21:09:19

Okay, finally got this tested, it is working well as expected.

By: Mark Spencer (markster) 2005-06-18 13:26:36

How about just making it an option which doesn't permit you to enter a digit which isn't part of a valid extension, wouldn't that be good enough?

By: Michael Jerris (mikej) 2005-06-19 22:47:41

Attached as background.matchexten.txt is a quick hack at the idea of optionally matching to a valid single digit exten and only doing doing stoping the stream if a valid extension is hit.  Also, as a freebee I threw in specifying an exit context for background.  I think that allowing the extension match behavior for anything more than single digit extensions would be very counter intuitive for a user, so I did not add any code to address collecting a list of digits.  All code and formating review aside, are the ideas in this more to what you were thinking?  Also, as a seperate bug after this, I will go in and consolidate all of the waitstream (and probably some of the wait) functions into a single function, as they are largely duplicate code.

By: Michael Jerris (mikej) 2005-06-20 22:22:53

Ok, spoke to kpfleming about this.  I will work on creating and testing some patches and will post when ready.

By: Michael Jerris (mikej) 2005-06-28 23:12:53

updated 4511rev0.patch.txt.  Still need to test.  If anyone wants to give it a try, have a ball.  Why do we have seperate apps for background and playback when they are almost identical?

By: Michael Jerris (mikej) 2005-06-29 23:11:24

The patch came out a little werid in file.c because the function above has the same end as the new functiton.  Fixed all the compiler errors.  Working on testing now.

By: Michael Jerris (mikej) 2005-06-30 00:06:53

ok, tested and working.. somone code review me babay...

By: Kevin P. Fleming (kpfleming) 2005-07-11 21:26:11

Committed to CVS HEAD, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:40:52.000-0600

Repository: asterisk
Revision: 6093

U   trunk/file.c
U   trunk/include/asterisk/file.h
U   trunk/pbx.c

r6093 | kpfleming | 2008-01-15 15:40:52 -0600 (Tue, 15 Jan 2008) | 2 lines

add 'exit context' and 'only stop on match' options to Background app (bug ASTERISK-4395)