[Home]

Summary:ASTERISK-04393: Build date omitted in version string on non-GNU systems
Reporter:David McNett (nugget)Labels:
Date Opened:2005-06-10 12:44:31Date Closed:2008-01-15 15:38:44.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) make_build_h.patch
Description:The make_build_h script fails to include the build date on non-GNU systems.  "date --utc" is a GNU-ism and is not portable to *BSD, OS X, Solaris, etc.   The "date --utc" should rather be "date -u" to ensure best portability.

--- make_build_h.orig   Fri Jun 10 12:34:47 2005
+++ make_build_h        Fri Jun 10 12:34:55 2005
@@ -4,7 +4,7 @@
MACHINE=`uname -m`
OS=`uname -s`
USER=`whoami`
-DATE=`date --utc "+%Y-%m-%d %H:%M:%S"`
+DATE=`date -u "+%Y-%m-%d %H:%M:%S"`
cat << END
/*
 * build.h
Comments:By: Clod Patry (junky) 2005-06-10 12:57:13

Please attach patches like said in the bug guidelines.
Thanks.
By: David McNett (nugget) 2005-06-10 13:06:38

Seemed silly for a three byte change, but OK.  Is there a way to change the summary to indicate [patch]?


By: Kevin P. Fleming (kpfleming) 2005-06-20 21:04:55

Committed to CVS HEAD, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:38:44.000-0600

Repository: asterisk
Revision: 5948

U   trunk/build_tools/make_build_h

------------------------------------------------------------------------
r5948 | kpfleming | 2008-01-15 15:38:43 -0600 (Tue, 15 Jan 2008) | 2 lines

ensure script is portable to non-GNU systems (bug ASTERISK-4393)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5948