Summary:ASTERISK-04363: [ASTCC] - Call Rating Issues - Patch Included
Reporter:Darren Wiebe (darren)Labels:
Date Opened:2005-06-06 19:43:15Date Closed:2005-08-22 20:54:28
Versions:Frequency of
Environment:Attachments:( 0) astcc.agi.patch1
Description:I believe ASTCC bills calls slightly higher than they should be billed.  If you manually calculate the cost of calls they come out less expensive than the way ASTCC bills them.  I have a patch attached for that.  I'm using it one my system.  BTW, you do have a disclaimer from me.
Comments:By: Kevin P. Fleming (kpfleming) 2005-06-17 11:08:03

Can we get some confirmation from other ASTCC users that this patch is the right thing to do? I'd think that if it was incorrectly calculating costs we'd have already heard about it :-)

By: Darren Wiebe (darren) 2005-06-18 08:40:36

This shows the way that I'm calculating call charges in this patch:

$bill_increments = round up("total billable seconds" - "Seconds included in the connect charge"/increments)

$billseconds = $billincrements * increments

$cost = ($bill_seconds / 60) * "marked up per minute rate" + "connection cost"

By: Mark Spencer (markster) 2005-06-18 12:04:39

The originaly code does not include support for "included seconds" right?  Is that all that is wrong with it?

By: Darren Wiebe (darren) 2005-06-18 16:34:01

I think you might be right.  I took another close look at it with my calculator.  I have posted a proposed fix to the mailing list.  We'll see what comes for comments.  BTW, the proposed fix is much simpler/smaller than my fix.

By: Michael Jerris (mikej) 2005-06-23 06:26:41

update on this please?

By: Darren Wiebe (darren) 2005-06-27 21:52:28

Nobody seems to care/have time for comments.  Maybe we should just drop it. :-)   If everyone is happy with the way it is done.  There is no point in changing it.  :-)

By: Michael Jerris (mikej) 2005-06-27 22:25:44

Closed at users request.

By: Darren Wiebe (darren) 2005-06-29 20:17:21

Due to issues that have come up on the mailing list, I would appreciate if we could reopen this.

By: Michael Jerris (mikej) 2005-06-29 20:22:02

Well, it's reopened.  Can you provide feedback on the calculation as requested please.

By: Darren Wiebe (darren) 2005-06-29 20:38:53

There was another issue with a variable not getting passed however I have fixed that in the file astpp.patch. I have also added support for the connected seconds.

By: Kevin P. Fleming (kpfleming) 2005-07-07 19:48:02

OK, there are two patches here, which one (or both) needs to be applied, and have we confirmed that this change will not cause breakage with people's existing calculations?

By: Michael Jerris (mikej) 2005-07-20 19:04:09

bug suspended due to lack of response.  feel free to re-open when you have updates.

By: Darren Wiebe (darren) 2005-07-23 08:49:16

I finally have an update. I have heard of several users who are using the patched version with good success.  As to it breaking peoples billing setup....  If they setup their software correctly, it should not break anything but it will, in most cases, be billing the calls slightly cheaper than it used to.

By: Darren Wiebe (darren) 2005-07-25 16:56:36

Rusty Shackleford pointed out a small error in the astcc.agi patch.  I have fixed it.  I unintentionally uploaded astcc-admin.cgi.patch here and I can't remove it.  Would it be possible to get the ability to delete patches as all of these should go except the last one?

By: Michael Jerris (mikej) 2005-07-25 16:59:08

can we get some outside testing comments on this?

By: Darren Wiebe (darren) 2005-08-04 18:50:43

This is from asterisk-users referring to this patch:

Thanks Darren,

i applied the patch you mentioned and now i have billing cost.

I have to check it more, in the following days but i think that the patch
did the right thing!


By: Kevin P. Fleming (kpfleming) 2005-08-22 20:54:03

Committed to CVS HEAD, thanks!