| Summary: | ASTERISK-04348: [patch] Fixed some stuff in sounds.txt | ||
| Reporter: | Clod Patry (junky) | Labels: | |
| Date Opened: | 2005-06-04 11:48:52 | Date Closed: | 2008-01-15 15:37:09.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Documentation |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) sounds_rev1.txt | |
| Description: | There was 2 entries of privacy-* with will_be_added_later. I've remove 2 entries of at.gsm, cause we can use just one. Is there any reason of having two files saying the same stuff: - privacy-thankyou.gsm and auth-thankyou.gsm is there any reason why these 2 files streaming the same thing in 2 different files? Any flexibility i guess. I can make a patch to app_privacy.c if necessery. Having a clean file is important when using that file to port all these sounds to a new language. ****** ADDITIONAL INFORMATION ****** Disclaimer on file. | ||
| Comments: | By: Michael Jerris (mikej) 2005-06-04 13:06:58 Is the privacy stuff from bug 752? If so that one is pretty close to going in. Just want to make sure we are not breaking that patch. By: Clod Patry (junky) 2005-06-04 14:04:32 No, see these files are different files (privacy-* from ASTERISK-746 aren't added yet to sounds.txt). Plus, i just realized, pbx-invalid.gsm invalid.gsm says the same thing (I am sorry, that's not a valid extension. Please try again.) , could we use the same file instead of these 2? Which one do u prefer to keep? i'll make the patch right after. By: Kevin P. Fleming (kpfleming) 2005-06-05 10:38:04 We need to leave the duplicate sound files in place, since user's dialplans may already be using them, and there is no major benefit to removing them. Committed to CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:37:09.000-0600 Repository: asterisk Revision: 5842 U trunk/sounds.txt ------------------------------------------------------------------------ r5842 | kpfleming | 2008-01-15 15:37:09 -0600 (Tue, 15 Jan 2008) | 2 lines minor cleanups (bug ASTERISK-4348) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5842 | ||