[Home]

Summary:ASTERISK-04342: [patch] 'send text' CLI function in chan_alsa only sends one character.
Reporter:Sarah Nordstrom (sarahemm)Labels:
Date Opened:2005-06-03 18:25:36Date Closed:2011-06-07 14:10:09
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) alsa.sendtext.fix-20050612-sn.diff
Description:The 'send text' CLI function used with chan_alsa to send text over the channel is only able to send one character at a time.

****** ADDITIONAL INFORMATION ******

The console_sendtext function in channels/chan_alsa.c pushes an entire string into one frame when called, however each frame is only supposed to have one character in it.  The function should push each character one by one as individual frames, instead of using one frame with the entire string in it.
Comments:By: Sarah Nordstrom (sarahemm) 2005-06-08 15:26:51

Something in the later HEAD has broken the patch attached to this bug entry.  I'm working on a new patch now to make it work again.
By: Sarah Nordstrom (sarahemm) 2005-06-12 12:38:51

Uploaded patch alsa.sendtext.fix-20050612-sn.diff which obsoletes patch alsa.sendtext.fix-20050603-sn.diff (which can now be deleted).  This patch works against the latest HEAD.
I am unsure exactly how the locking should be done around each frame being queued, so this will need looking over by someone more experienced in the ways of locking.  The patch has been tested and does function as expected on my system, I'm just not 100% sure how the locking should be done.
By: Sarah Nordstrom (sarahemm) 2005-06-12 14:18:05

Nevermind.  After discussing this with other devs, this isn't the way to do this.  Both patches attached to this bug are now obsolete.  It's the AGI functions that need fixing, not the alsa channel code.  Close this bug, please, i'll open a new one once I have the AGI stuff fixed.
By: Russell Bryant (russell) 2005-06-12 14:21:04

closed per bug placer's request