[Home]

Summary:ASTERISK-04310: [patch] hebrew say number
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2005-06-01 05:13:50Date Closed:2008-01-15 15:40:59.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/Internationalization
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) say_he.2.head.diff.txt
( 1) say_he.3.diff.txt
( 2) say_he.3.head.diff.txt
Description:support for saying numbers in Hebrew. Should support numbers up to 1,000,000 but I haven't tested it much.

Seems to work with 1.0.7 and to apply cleanly with HEAD. Quite basic. Works for numbers, but doesn't seem good enough yet for dates.

****** ADDITIONAL INFORMATION ******

When running 'SayUnixTime' it says '2' and 'thousand' instead of '2thousand' for the year. I fail to understand why. I probably need to handle the date explicitly.

There's no disclaimer yet as I know that this patch is not good enough to be included.

This patch with a set of Hebrew digits I've recorded could be fetched from http://tzafrir.org.il/say_he.tgz . Naturally the quality of those sounds is horrible :-)
Comments:By: Clod Patry (junky) 2005-06-01 11:38:58

3 things:
1. You should send your disclaimer, cause there will have not wasted time if any decision related to commit of that patch.

2. Why are you making any calling of ast_say_number_full_fr in that function?

3.
asterisk:/usr/src/asterisk# patch -p0 < say_he.diff
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urNad asterisk-1.0.7/say.c /tmp/dpep.HOL8qa/asterisk-1.0.7/say.c
|--- asterisk-1.0.7/say.c       2004-12-22 08:18:32.000000000 +0200
|+++ /tmp/dpep.HOL8qa/asterisk-1.0.7/say.c      2005-06-01 00:45:34.279576322 +0300
--------------------------
File to patch: say.c
patching file say.c
Hunk #1 FAILED at 448.
Hunk #2 succeeded at 551 (offset 45 lines).
Hunk #3 succeeded at 1288 with fuzz 2 (offset 307 lines).
1 out of 3 hunks FAILED -- saving rejects to file say.c.rej
asterisk:/usr/src/asterisk#


So please provide a patch for HEAD, cause anyways, it'll be added to HEAD, not stable at a first time.


By: nirsim (nirsim) 2005-06-06 04:37:58

Hi Tafrir,

 I started working on a similar patch for this, and I also have studio quality recordings we can donate into the project for this purpose. If we are already on the roll here, why not also implement Arabic, the syntactical grammer isn't all the different as far as I can recall, and I already have the recordings for that.

 I would also like to help out on this. Do you have a CVS server you are working on somewhere for these purposes?

Nir S
By: Clod Patry (junky) 2005-06-06 07:10:44

tzafrir: we need feedback here.
By: Tzafrir Cohen (tzafrir) 2005-06-08 09:33:12

This one is not a final version either, but is much better than the ealier. As it includes many changes, I figured I better submit it here.

It includes handling of the date formatting function as well. A big problem is that SayUnixTime will still use the default English format rather than "the default locale format" (%c in strftime).

This one is still not disclaimed as my boss was not at work today. Maybe tommorow. But anyway, I suspect it will have the same problems as the earlier one. I only added options.h to allow some debugging usage of ast_verbose, which should be later removed.
By: Clod Patry (junky) 2005-06-08 11:13:27

You should write patch against CVS-HEAD, not against stable branch.
By: Tzafrir Cohen (tzafrir) 2005-06-08 12:22:12

Compiles. That is as much as I can test with HEAD.
By: Tzafrir Cohen (tzafrir) 2005-06-12 03:44:28

Uploaded a slightly fixed version (this one should at least get the m/f basically right). As usual: the .head version is only tested to basically compile, as my CVS HEAD doesn't properly build (due to lack of a separate chroot to build it in).

A disclaimer for both files should be on its way.
By: Michael Jerris (mikej) 2005-06-12 08:10:37

As this will not go into the 1.0.x branch, we really need somone to test this out on the head branch.
By: Kevin P. Fleming (kpfleming) 2005-06-23 23:06:18

The patch does look ready to commit, but since I don't have sounds nor do I speak Hebrew I can't test it... can you post a request to the asterisk-dev list for some additional testers?
By: Michael Jerris (mikej) 2005-06-23 23:11:26

If somone can get sounds, I can get people to test this.
By: Kevin P. Fleming (kpfleming) 2005-07-11 22:52:52

Committed to CVS HEAD, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:40:59.000-0600

Repository: asterisk
Revision: 6101

U   trunk/say.c

------------------------------------------------------------------------
r6101 | kpfleming | 2008-01-15 15:40:59 -0600 (Tue, 15 Jan 2008) | 2 lines

add support for say_number in Hebrew (bug ASTERISK-4310)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6101