Summary:	ASTERISK-04301: [patch] wrong args to ast_copy_string in chan_sip.c:reply_digest()
Reporter:	Luigi Rizzo (rizzo)	Labels:
Date Opened:	2005-05-29 20:01:07	Date Closed:	2011-06-07 14:10:41
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_adsi
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) sip.diff
Description:	near the end of function reply_digest, there is a bunch of calls to ast_copy_string with the size arg referring to a field of a different data structure, although with the same name and possibly size. The attached patch fixes this. Once again this kind of bugs would have been impossible by using proper macros for string handling as the ones i suggested in ASTERISK-4070 ****** ADDITIONAL INFORMATION ****** reply_digest() suffers from cut&paste abuse - the same block of 11 lines is repeated five times. Patch coming for this as well.
Comments:	By: Michael Jerris (mikej) 2005-05-30 22:33:10 looks like mark commited this to head.. ast_copy_string is not in stable. By: Michael Jerris (mikej) 2005-05-30 22:37:54 Maybe we should double check and make sure it is not the same issue w/ strcpy in stable. By: Russell Bryant (russell) 2005-05-30 22:44:18 fixed in 1.0 as well :) By: Digium Subversion (svnbot) 2008-01-15 15:36:20.000-0600 Repository: asterisk Revision: 5785 U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r5785 | markster | 2008-01-15 15:36:19 -0600 (Tue, 15 Jan 2008) | 2 lines Fix reply digest selection of size (bug ASTERISK-4301) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5785 By: Digium Subversion (svnbot) 2008-01-15 15:36:27.000-0600 Repository: asterisk Revision: 5793 U   branches/v1-0/channels/chan_sip.c ------------------------------------------------------------------------ r5793 | russell | 2008-01-15 15:36:26 -0600 (Tue, 15 Jan 2008) | 2 lines Fix reply digest selection of size (bug ASTERISK-4301) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5793