[Home]

Summary:ASTERISK-04280: [PATCH] chan_sip.c bug in maddr handling in set_destination
Reporter:timecop (timecop)Labels:
Date Opened:2005-05-26 03:59:51Date Closed:2008-01-15 15:36:08.000-0600
Priority:BlockerRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:cvs diff -ur 1.722 -r 1.723 channels/chan_sip.c
old, working code broken by this change, patch attached


****** ADDITIONAL INFORMATION ******

patch:

--- chan_sip.c  25 May 2005 20:03:09 -0000      1.742
+++ chan_sip.c  26 May 2005 08:57:07 -0000
@@ -3459,7 +3459,7 @@
               maddr += 6;
               hn = strspn(maddr, "0123456789.") + 1;
               if (hn > sizeof(hostname)) hn = sizeof(hostname);
-               ast_copy_string(hostname, h, hn);
+               ast_copy_string(hostname, maddr, hn);
       }
       
       hp = ast_gethostbyname(hostname, &ahp);
Comments:By: Michael Jerris (mikej) 2005-05-26 08:31:06

Please attach the patch as a file (with .txt file extension for some who have issues opening) thanks.  Without looking at the code, indentaion looks not right on that line.. could you double check and fix that up while your in there please.
By: Mark Spencer (markster) 2005-05-26 11:04:28

Fixed in CVS head, i just made the change by hand and didn't use the patch.
By: Michael Jerris (mikej) 2005-05-30 23:28:57

Already correct in stable.  This seems to have been broken in the conversion to ast_copy_string.
By: Digium Subversion (svnbot) 2008-01-15 15:36:08.000-0600

Repository: asterisk
Revision: 5772

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r5772 | markster | 2008-01-15 15:36:08 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix typo about maddr (bug ASTERISK-4280)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5772