Summary:ASTERISK-04278: [patch] ExecIfTime kills your call when outside the timespec
Reporter:Anthony Minessale (anthm)Labels:
Date Opened:2005-05-25 19:51:10Date Closed:2011-06-07 14:09:59
Versions:Frequency of
Environment:Attachments:( 0) execiftime_fix.rev0.diff
( 1) pbx.diff
Description:This patch fixes the ExecIfTime app which currently will return -1 if the current time is outside the timespec rather than continue on in the dialplan as intended.


Disclaimer on file
Comments:By: Russell Bryant (russell) 2005-05-26 11:51:16

I'm sorry for breaking this :(

I have added this to CVS HEAD with a minor tweak to check the value of res before calling ast_check_timing

By: Brian West (bkw918) 2005-08-15 11:31:28

Checking res before the time spec will ALWAYS FAIL... you broke it when you did if !res because res is init at 0 thus false and execiftime has been broken once again.


By: Russell Bryant (russell) 2005-08-19 02:47:21

you are right that it is wrong, but res being initialized to zero has *nothing* to do with it.  As a matter of fact, checking !res after setting it to zero would evaluate to *true*.

Anyway, it's fixed ...

By: Digium Subversion (svnbot) 2008-01-15 15:36:09.000-0600

Repository: asterisk
Revision: 5773

U   trunk/pbx.c

r5773 | russell | 2008-01-15 15:36:09 -0600 (Tue, 15 Jan 2008) | 2 lines

fix return value for ExecIfTime when time is outside of the specified range (bug ASTERISK-4278)



By: Digium Subversion (svnbot) 2008-01-15 15:44:34.000-0600

Repository: asterisk
Revision: 6343

U   trunk/pbx.c

r6343 | russell | 2008-01-15 15:44:34 -0600 (Tue, 15 Jan 2008) | 2 lines

fix execiftime and include some code cleanup while we're at it (bug ASTERISK-4278)