| Summary: | ASTERISK-04262: [PATCH] making H.323 noSilenceSuppression work | ||
| Reporter: | Wojtek Kaniewski (wojtekka) | Labels: | |
| Date Opened: | 2005-05-24 04:13:51 | Date Closed: | 2011-06-07 14:10:34 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) asterisk-cvs-h323-silence-detection.patch | |
| Description: | Silence suppression disabling code was removed from the source, probably because of OpenH323 API change. The following patch makes H.323 channel driver use the new API. Unfortunatelly C++ isn't my native language, so only global noSilenceSuppression works (but hey, it's better than nothing!) ****** ADDITIONAL INFORMATION ****** Disclaimer on file. | ||
| Comments: | By: Wojtek Kaniewski (wojtekka) 2005-05-24 04:28:07 Argh, sorry for my bad English, but I misunderstood the ,,Disclaimer on file'' phrase seen on other bugreports. I haven't signed any disclaimer yet. I just wanted to say that I disclaim any copyrights for the attached file. It's a trivial patch, so printing, signing and mailing/faxing the disclaimer would take more time than rewriting the patch by one of the developers. By: Paul Cadach (pcadach) 2005-05-25 05:23:32 Is uncommenting a block before your addition and fixing typo in constant name helps? By: Wojtek Kaniewski (wojtekka) 2005-05-25 07:19:52 No, it doesn't even compile. It seems that silence suppression in OpenH323 has been moved from H323Connection to audio codecs and probably that's why the previous code has been disabled. By: Paul Cadach (pcadach) 2005-05-25 07:22:46 I'll try to look deeper this evening. By: Michael Jerris (mikej) 2005-06-19 12:23:21 Update please? By: Michael Jerris (mikej) 2005-07-12 17:11:34 Suspended due to lack of response from OP and others. If anyone is still interested in this, please re-open the bug. | ||