Summary:ASTERISK-04247: [patch] adds AST_MAX_ACCOUNT_CODE def to cdr.h
Reporter:cmaj (cmaj)Labels:
Date Opened:2005-05-20 13:16:13Date Closed:2008-01-15 15:36:02.000-0600
Versions:Frequency of
Environment:Attachments:( 0) ast_max_account_code.diff1.txt
Description:This should help eliminate the use of 20 as a magic number for the accountcode throughout the code and therefore bugs related to its usage.  Possibly corrected one in chan_skinny, where the accountcode was being given size 80.  Kind of borrowing from the AST_MAX_USER_FIELD.

Note that I didn't adjust the definitions in the cdr/cdr_* files because I wasn't sure how to do that, or in any of the documentation.  I can do that in another patch if this one gets the okay for inclusion.


Disclaimer on file.
Comments:By: Mark Spencer (markster) 2005-05-25 13:14:21

Added to CVS, thanks!

By: Russell Bryant (russell) 2005-05-30 22:37:52

not included in 1.0, since it's not really necessary in this case :)

By: Digium Subversion (svnbot) 2008-01-15 15:36:02.000-0600

Repository: asterisk
Revision: 5765

U   trunk/cdr.c
U   trunk/channels/chan_iax2.c
U   trunk/channels/chan_mgcp.c
U   trunk/channels/chan_sip.c
U   trunk/channels/chan_skinny.c
U   trunk/channels/chan_zap.c
U   trunk/channels/h323/chan_h323.h
U   trunk/include/asterisk/cdr.h
U   trunk/include/asterisk/channel.h

r5765 | markster | 2008-01-15 15:36:02 -0600 (Tue, 15 Jan 2008) | 2 lines

Use defined AST_MAX_ACCOUNT_CODE (bug ASTERISK-4247)