Summary:ASTERISK-04245: [patch] stop playing beep when starting to spy on a channels and the 'q' option is supplied
Reporter:cmaj (cmaj)Labels:
Date Opened:2005-05-20 11:58:22Date Closed:2008-01-15 15:36:10.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_chanspy_quiet_means_no_beeps.diff1.txt
Description:My understanding of the 'q' option to chanspy was that it should eliminate all beeps, but there's still a beep when starting to spy on some channels.  Small patch fixes that.


Disclaimer on file.
Comments:By: twisted (twisted) 2005-05-25 00:51:05

should we be clearing the flag only if not in silent mode?  I suspect we should only put the if (!silent) around the stream functionaility.

By: Michael Jerris (mikej) 2005-05-25 06:52:03

Also we need testers on this.

By: Anthony Minessale (anthm) 2005-05-26 11:50:51

this patch is ok,

the flag is only cleared if the sound plays and the waitstream failed (hangup) if you never stream you never need to wait so it's fine. That flag is there to keep channels from spying on each other while spying cos it seemed too crazy to manage. and it will be cleared for sure before the code exits.

By: Russell Bryant (russell) 2005-05-26 12:02:19

added to CVS HEAD, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:36:10.000-0600

Repository: asterisk
Revision: 5774

U   trunk/apps/app_chanspy.c

r5774 | russell | 2008-01-15 15:36:09 -0600 (Tue, 15 Jan 2008) | 2 lines

don't play any sounds when using the quiet option (bug ASTERISK-4245)