Summary:	ASTERISK-04223: setting rtptimeout per peer basis does not work (probalby rtpholdtimeout, rtpkeepalive too)
Reporter:	Kevin P. Fleming (kpfleming)	Labels:
Date Opened:	2005-05-19 00:45:01	Date Closed:	2011-06-07 14:10:02
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 4325.stable.patch.txt
Description:	If you set rtptimout for given peer like this:<br /> [peer1]<br /> rtptimout=10<br /> <br /> it is NOT USED (in sip_chan.c:do_monitor()), instead global setting ([general]), if any, is used.<br /> <br /> In chan_sip.c there is do_monitor() which looks uses sip_pvt structure<br /> to obtain value of rtptimout but this value is always global one.<br /> <br /> I've added following in create_addr():<br />  if (p->rtptimeout != 0)<br />    r->rtptimeout = p->rtptimeout;<br /> I am not sure if it is the (only) place were this should be initialized.<br /> <br /> Probalby the same aplies to rtpholdtimeout, rtpkeepalive.<br />
Comments:	By: Michael Jerris (mikej) 2005-05-31 01:16:46 Patch uploaded.  Note that in head, a patch was commited, then reverted, then a diff patch commited, this is the second patch from head. By: Russell Bryant (russell) 2005-05-31 01:27:23 fixed in 1.0 with a slightly modified patch ... that 3rd option is not supported in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:36:33.000-0600 Repository: asterisk Revision: 5800 U   branches/v1-0/CHANGES U   branches/v1-0/channels/chan_sip.c ------------------------------------------------------------------------ r5800 | russell | 2008-01-15 15:36:32 -0600 (Tue, 15 Jan 2008) | 2 lines fix rtptimeout options for a specific peer (bug ASTERISK-4223) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5800