Summary:ASTERISK-04215: [patch] s extension is not used on incoming overlap call without extension
Reporter:klaus3000 (klaus3000)Labels:
Date Opened:2005-05-18 07:03:11Date Closed:2008-01-15 15:38:05.000-0600
Versions:Frequency of
Environment:Attachments:( 0) asterisk-overlap-s-extension-CVS.1.patch.txt
( 1) asterisk-overlap-s-extension-stable.1.patch.txt
Description:When an overlap call is received, and there is no Called Number specified, the 's' extension is not used, but asterisk just hangs up. If the incoming call has "sending complete", the 's' extension is used.

In Austria, the TON for the called number is typically "unknown", thus if someone dials the line number without specifying an extension, the incoming SETUP message does not include a "Called Number" IE.


I made a patch, which verifies the length of the extension in the ss_thread, just after receiving the overlap digits. If the len is zero, the 's' extension will be used. I'm not familiar with asterisk code, thus I'm not sure if this was the right position to put the check.

Both patches are tested on my incoming PRI. IMO this is a bug, thus please submit into stable too (or make an appropriate patch).

I'm trying to fax the disclaimer, but the fax machines fail to communicate. May I scan the disclaimer and send it via email?
Comments:By: Russell Bryant (russell) 2005-05-18 20:00:25

A disclaimer by email is fine.  You can email it to russell@digium.com and I will take care of it.


By: Clod Patry (junky) 2005-05-18 23:37:35

And try to attach patches as a .txt extension, so every windows users will be able to open it directly.

By: klaus3000 (klaus3000) 2005-05-19 01:13:58

Disclaimer sent by email. I also uploaded the patch again with .txt extension. I also tried to delete the old ones, but it failed :-(

By: klaus3000 (klaus3000) 2005-06-08 13:02:17

This patch is now running in an office with typical >10 concurrent calls for 2 weeks without problems.

By: Kevin P. Fleming (kpfleming) 2005-06-09 18:32:37

Committed to CVS HEAD, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:37:56.000-0600

Repository: asterisk
Revision: 5893

U   trunk/channels/chan_zap.c

r5893 | kpfleming | 2008-01-15 15:37:56 -0600 (Tue, 15 Jan 2008) | 2 lines

make incoming overlap calls with no number specified use the 's' extension (bug ASTERISK-4215)



By: Digium Subversion (svnbot) 2008-01-15 15:38:05.000-0600

Repository: asterisk
Revision: 5903

U   branches/v1-0/channels/chan_zap.c

r5903 | russell | 2008-01-15 15:38:05 -0600 (Tue, 15 Jan 2008) | 2 lines

if no extension is specified on an overlap call, use the 's' extension (bug ASTERISK-4215)