| Summary: | ASTERISK-04201: [patch] chan_sip.c does not compile | ||
| Reporter: | Luigi Rizzo (rizzo) | Labels: | |
| Date Opened: | 2005-05-17 03:59:15 | Date Closed: | 2008-01-15 15:35:26.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) sip.diff | |
| Description: | channels/chan_sip.c::build_user() has some variable declarations after code, which is a C++-ism and prevents it from compiling with gcc 2.95 or any compiler flags which disables C++ extensions. Same problem in function build_peer() Trivial patch attached. Probably one should use stricter gcc options to explicitly disallow such extension in the interest of portability. Severity should be "does not compile" but there is no such an option :) ****** ADDITIONAL INFORMATION ****** disclaimer on file | ||
| Comments: | By: Olle Johansson (oej) 2005-05-17 16:50:30 Recommended for CVS. I did not catch this since I was forced to upgrade to gcc 3 :-) By: Kevin P. Fleming (kpfleming) 2005-05-18 22:44:34 Committed to CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:35:26.000-0600 Repository: asterisk Revision: 5724 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r5724 | kpfleming | 2008-01-15 15:35:25 -0600 (Tue, 15 Jan 2008) | 2 lines move variable declarations to top of function where they belong (bug ASTERISK-4201) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5724 | ||