[Home]

Summary:ASTERISK-04197: While rinning Festival application: runs 1,3,5,.. produce valid sound and runs 2,4,6,... produce only noise
Reporter:Alexander Gorovoy (agorov)Labels:
Date Opened:2005-05-16 17:38:09Date Closed:2008-01-15 15:36:34.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_festival
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 4299.stable.patch.txt
Description:While rinning Festival application like:

exten => 4332,1,Answer
exten => 4332,2,Festival('Hello man you called ${EXTEN}')
exten => 4332,3,Hangup

Consequitive commands

*CLI> dial 4332
*CLI> dial 4332
*CLI> dial 4332
*CLI> dial 4332
...

produce valid sound in runs 1,3,5,... and produce only noise in runs 2,4,6,...

Setup:
1. Asterisk ver. 1.0.7 compiled from release sources
2. Festival of any version (tried 1.4.2 and 1.95) running in server mode.







****** ADDITIONAL INFORMATION ******

Most probable reason for the bug is in file app_festival.c, line 134:  
write(fd,"a",1);
(Probably forgotten debug statement)
Removing this line fixes the problem.
It is for sure not a festival problem as I checked the binary
data returned from festival to the asterisk and the data is identical
for odd and even runs of the app_festival.
Comments:By: Alexander Gorovoy (agorov) 2005-05-16 17:40:27

The dialing is performed from the console and the output device is OSS/dsp.
By: twisted (twisted) 2005-05-16 18:16:27

if you are providing a patch, please provide it in unified diff format.
By: twisted (twisted) 2005-05-16 18:16:44

Also, this is certainly not Major.
By: Kevin P. Fleming (kpfleming) 2005-05-19 00:54:55

Well, that does clearly seem to be an error, but according to CVS that line has been there for over 2 years without any other problem reports...
By: Kevin P. Fleming (kpfleming) 2005-05-19 00:55:36

Can you confirm that there is no reason to be sending an "a" down a channel's audio path here?
By: Mark Spencer (markster) 2005-05-23 00:58:07

I didn't write the application, so I have no explanation for the superfluous "a"
By: Russell Bryant (russell) 2005-05-23 19:12:26

Yes, that line makes no sense to me either.  I'm going to go ahead and commit this patch, and if it breaks stuff, we will surely hear about it.  :)
By: Russell Bryant (russell) 2005-05-23 19:13:27

fixed in CVS HEAD
By: twisted (twisted) 2005-05-25 00:47:21

someone forgot to update the status. :)
By: twisted (twisted) 2005-05-25 00:47:40

nevermind.. I can't read.
By: Michael Jerris (mikej) 2005-05-31 01:05:16

patch for stable identical to what was applied for head..
By: Russell Bryant (russell) 2005-05-31 08:48:45

fixed in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:35:54.000-0600

Repository: asterisk
Revision: 5756

U   trunk/apps/app_festival.c

------------------------------------------------------------------------
r5756 | russell | 2008-01-15 15:35:54 -0600 (Tue, 15 Jan 2008) | 2 lines

remove seemingly useless write (bug ASTERISK-4197)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5756
By: Digium Subversion (svnbot) 2008-01-15 15:36:34.000-0600

Repository: asterisk
Revision: 5801

U   branches/v1-0/apps/app_festival.c

------------------------------------------------------------------------
r5801 | russell | 2008-01-15 15:36:33 -0600 (Tue, 15 Jan 2008) | 2 lines

remove seemingly bogus line (bug ASTERISK-4197)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5801