| Summary: | ASTERISK-04181: [patch] Eliminate hidden copying when passing structures as arguments, small memory leak fix | ||
| Reporter: | Paul Cadach (pcadach) | Labels: | |
| Date Opened: | 2005-05-15 23:21:27 | Date Closed: | 2008-01-15 15:35:39.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) ast-h323-structargs.diff | |
| Description: | This patch changes passing of structures as arguments by reference rather than by value (requires more memory and hidden copy of structure's data). Additionaly, this helps to eliminate memory leak caused by preparing call_details_t on ast_h323.cxx, duplicating values at chan_h323.c and no cleanup at ast_h323.cxx. Current design requires setup_incoming_call()/setup_outgoing_call() functions to handle call details or cleanup all allocated values. And, small formatting fixes too, of course. ****** ADDITIONAL INFORMATION ****** Disclaimer is on file. | ||
| Comments: | By: jerjer (jerjer) 2005-05-19 12:12:39 fixed in -head By: jerjer (jerjer) 2005-05-19 12:12:59 not in -stable By: Digium Subversion (svnbot) 2008-01-15 15:35:39.000-0600 Repository: asterisk Revision: 5739 U trunk/channels/chan_h323.c U trunk/channels/h323/ast_h323.cpp U trunk/channels/h323/chan_h323.h ------------------------------------------------------------------------ r5739 | jeremy | 2008-01-15 15:35:39 -0600 (Tue, 15 Jan 2008) | 2 lines Fix memory leak, avoid uncessary abuse of memory and formatting tweaks. Bug ASTERISK-4181 ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5739 | ||