[Home]

Summary:ASTERISK-04169: [patch] [post 1.2] MeetMe cleanup, redesign process
Reporter:mochouinard (mochouinard)Labels:
Date Opened:2005-05-14 19:35:29Date Closed:2005-08-27 01:16:01
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:This is not actually a patch, but the full C file.  It intended to be the base for the next MeetMe.  I tryed to cleanup conf_run as much as possible so it look better.    It will have a context base configuration file and backward compability with the room context will be added latter.  At this point, I want some comments on this and see if it a good base to start adding features.

****** ADDITIONAL INFORMATION ******

I havent had much time in the last too week to work on it, I had a few hours yesterday and today to cleanup some stuff.  I'dlike to have comment on it so I dont have to waist my time like I did before.  Thanks
Comments:By: mochouinard (mochouinard) 2005-05-15 09:52:38

Ok readded a few features :
extensions.conf
MeetMe(mastertest)

meetme.conf
[mastertest]
poundexit=yes
quiet=no
announcecount=yes
intro=yes
By: Clod Patry (junky) 2005-05-25 11:27:05

I really like that new support of classes, great job Moc.
maybe if you could list here all the default values, that would be great too.
By: Sandeep A.S (sandeep) 2005-06-07 09:14:06

I am getting the following error with the patch
I run from the directory /usr/src/asterisk and my version is
# asterisk -V
Asterisk CVS-HEAD-04/12/05-18:15:04

root@voipgate-in asterisk]# patch -p0 < app_meetme.c_redesign_rev2.txt
patch: **** Only garbage was found in the patch input.

I am not a programmer. What would be the mistake ?
By: Clod Patry (junky) 2005-06-07 10:03:40

that's not a patch, it's a full re-design.
By: Sandeep A.S (sandeep) 2005-06-08 03:35:01

So I can replace app_meetme.c with the new file correct ?


I tried this .Ie replaced the file them $make clean ; make.
but the following error.
app_meetme.c:38:22: asterisk.h: No such file or directory
app_meetme.c:39:21: astconf.h: No such file or directory
app_meetme.c: In function `nameannouncement':
app_meetme.c:416: error: `ast_config_AST_SPOOL_DIR' undeclared (first use in this function)
app_meetme.c:416: error: (Each undeclared identifier is reported only once
app_meetme.c:416: error: for each function it appears in.)
app_meetme.c: In function `conf_run':
app_meetme.c:697: warning: implicit declaration of function `ASTOBJ_CONTAINER_UNLINK'
app_meetme.c:697: warning: assignment makes pointer from integer without a cast
app_meetme.c:702: warning: assignment makes pointer from integer without a cast
make[1]: *** [app_meetme.o] Error 1
make[1]: Leaving directory `/usr/src/asterisk/apps'
make: *** [subdirs] Error 1
How I can get this functionallity ?
Outgoing from conference is a very good feature. Main advantage is that no need to plan for the conferance .Main user can make the conferance at any time .Also
employees need not to call the conference number,Admin can make the conferance in the expense of company conferance facilty not the expence of employees call.

Please advice me how to proceed ?


By: Clod Patry (junky) 2005-06-08 06:47:23

That patch doesn't apply to CVS-HEAD.
Moc, any plan to update it against current HEAD?


By: mochouinard (mochouinard) 2005-06-22 20:47:45

just remove the line : #include "astconf.h"
and it should work
By: mochouinard (mochouinard) 2005-07-19 08:19:06

This app currently have delay problem like current MeetMe app... Will try to build a brandnew conference engine, so it does not rely on ZapTel conference anymore.
By: Michael Jerris (mikej) 2005-07-19 11:10:53

as you are going totally back to the drawing board, leave this open or close out pending a new version?
By: Olle Johansson (oej) 2005-07-19 13:47:01

Moved the report to "Experimental features" while development is going on. Let's leave it open so people discover it.
By: mochouinard (mochouinard) 2005-08-26 22:52:49

There wont be any more update from me.  I got tired of fighting for something I do not use.  That was just to improve what was there already.  Anyone is welcome to continue what I have started under the GPL license....