[Home]

Summary:ASTERISK-04131: [patch] Swedish indications.conf.sample
Reporter:Daniel Nylander (yeager)Labels:
Date Opened:2005-05-10 14:32:29Date Closed:2008-01-15 15:36:56.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Resources/res_indications
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) patch-swedish-indications.conf-sample.diff
( 1) patch-swedish-indications.conf-sample-ver2.diff.txt
Description:Here is the tones for Swedish users

Courtesy of Tobias J├Ânsson at http://www.telesyd.se/
http://www.voip-info.org/wiki-Asterisk+indications+Sweden


+++ indications.conf.sample     2005-05-10 21:34:12.000000000 +0200
@@ -445,3 +445,16 @@
dialrecall = !350+440/100,!0/100,!350+440/100,!0/100,!350+440/100,!0/100,350+440
record = 1400/500,0/15000
info = 950/330,0/30,1400/330,0/30,1800/330,0/1000
+
+[se]
+description = Sweden
+ringcadance = 1000,5000
+dial = 425
+busy = 425/250,0/250
+ring = 425/1000,0/5000
+congestion = 425/250,0/750
+callwaiting = 425/200,0/500,425/200,0/8000
+info = 950/300,0/20,1400/300,0/20,1800/300,0/1000
+; dialrecall and record not necessarily these
+dialrecall = 425/325,0/25
+record = 1400/500,0/15000
Comments:By: twisted (twisted) 2005-05-10 22:55:45

can you please post your patch as a unified diff?

also, can someone verify that these are correct?  I can't find a source to confirm.

By: Daniel Nylander (yeager) 2005-05-11 12:56:35

Can you verify this?


By: Clod Patry (junky) 2005-05-11 21:14:59

Do you have disclaimer on file at digium?

By: petersv (petersv) 2005-05-12 00:51:33

These are not quite correct, I think. The call waiting cadence is slightly off. Also, the info is not strictly accroding the the Swedish specs, which say it should be repeated 5 times.

See the data in zonedata.c in zaptel, which should already be correct. I spent quite some time researching it. :)

By: Daniel Nylander (yeager) 2005-05-12 01:59:26

petersv: Can you make the appropriate changes and perhaps release a new patch?

By: Clod Patry (junky) 2005-05-30 23:02:03

true, in zonedata.c, isn't 8000, but 9100.


I suggest oej review this, since he's in Sweden.



By: Olle Johansson (oej) 2005-05-31 00:49:26

I fully trust petersv to have the correct data. As he says, the zonedata.c and indications.conf should have the same settings.

By: petersv (petersv) 2005-05-31 01:29:21

I forgot about this. I'll try to get a patch done tonight. My compilation environment is slightly broken at the moment, but I have to repair it anyway.

By: petersv (petersv) 2005-05-31 15:35:38

This is related to ASTERISK-1809.

I have added a modified version of the patch that is identical to the data in zonedata.c on zaptel. The data is in originally obtained from http://www.skanova.se/file/1%2D1551%2DLZBA+505+457+revB%5B1%5D.pdf?Path=2&ID=560&File=1%2D1551%2DLZBA+505+457+revB%5B1%5D.pdf



By: Clod Patry (junky) 2005-06-01 11:55:30

This seems okay to me.
petersv do u have disclaimer on file at digium?

By: petersv (petersv) 2005-06-01 12:11:50

Unfortunatly not. The legal department remains to overloaded to look at the disclaimer. It is a bit annoying, since we have to maintain several patches on our own.

The code is cut and pasted from zoneinfo.h. It is in no way a creative work.

By: Kevin P. Fleming (kpfleming) 2005-06-02 22:49:22

Since this is just a copy-and-paste (essentially), there is no disclaimer really needed. I've committed it to CVS HEAD, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:36:56.000-0600

Repository: asterisk
Revision: 5827

U   trunk/configs/indications.conf.sample

------------------------------------------------------------------------
r5827 | kpfleming | 2008-01-15 15:36:55 -0600 (Tue, 15 Jan 2008) | 2 lines

add indications for Sweden (bug ASTERISK-4131)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5827