[Home]

Summary:ASTERISK-04107: [patch] unreachable code in chan_features.c
Reporter:Luigi Rizzo (rizzo)Labels:
Date Opened:2005-05-07 11:13:01Date Closed:2011-06-07 14:10:42
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_features.c.diff
Description:channels/chan_features.c::features_new() has a block of unreachable code (see below) which prevents the printing of the error message. The attached patch moves the msg up consistently with the rest of the function.
NOTE -- after applying the patch, you should also move the block of code "dosomething" one level to the left to keep the indentation consistent. I have not included the whitespace change in the patch to avoid cluttering it.
disclaimer on file.

   if (!tmp)
        return NULL;
   if (tmp) {
         ... dosomething
   } else
-->     ast_log(...error message...)
Comments:By: Russell Bryant (russell) 2005-05-07 15:46:28

Fixed in CVS HEAD, Thanks!

Just to make sure that you know, chan_features is still highly experimental, and isn't even used for anything at this point, as far as I know.
By: Digium Subversion (svnbot) 2008-01-15 15:33:35.000-0600

Repository: asterisk
Revision: 5597

U   trunk/channels/chan_features.c

------------------------------------------------------------------------
r5597 | russell | 2008-01-15 15:33:35 -0600 (Tue, 15 Jan 2008) | 2 lines

now fix the formatting part (bug ASTERISK-4107)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5597
By: Digium Subversion (svnbot) 2008-01-15 15:33:35.000-0600

Repository: asterisk
Revision: 5596

U   trunk/channels/chan_features.c

------------------------------------------------------------------------
r5596 | russell | 2008-01-15 15:33:34 -0600 (Tue, 15 Jan 2008) | 2 lines

remove unreachable block of code (bug ASTERISK-4107)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5596