Summary:ASTERISK-04094: [patch] Some cleanups for C++ part
Reporter:Paul Cadach (pcadach)Labels:
Date Opened:2005-05-06 03:36:48Date Closed:2005-05-11 09:35:30
Versions:Frequency of
Environment:Attachments:( 0) ast-h323-cleanup.diff
Description:This patch is very simple and provides some code cleanup for C++ part of chan_h323.


Description of each change provided by this patch:
1) Don't try to evaluate formatting escape sequences possibly presented on OpenH323 traces

2) Log OpenH323 assertions as usual (i.e. on Asterisk's logs), continue execution (or we should crash? at least OpenH323 have workarounds for most assertion conditions);

3) Remove unneeded locking around GetCallToken() because we already have locks done at OpenH323 level;

4) Don't modify aliases passed to h323_set_alias() because it points to global alias structure initialized from configuration;

5) Perform reversal initialization of internal structures on shutdown (helps on sequential unload/load when the module isn't really unloaded).
Comments:By: Paul Cadach (pcadach) 2005-05-06 03:47:00

Of course, disclaimer is on file.

By: jerjer (jerjer) 2005-05-11 09:35:15

fixed in cvs -head.

By: jerjer (jerjer) 2005-05-11 09:35:30

not in -stable