Summary:	ASTERISK-04092: [patch] add more knobs to iax2 peer qualification system
Reporter:	kb1_kanobe2 (kb1_kanobe2)	Labels:
Date Opened:	2005-05-06 02:29:04	Date Closed:	2008-01-15 15:45:11.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chan_iax2.c.controlqualifypatch.v3
Description:	This tweak adds three new per-peer controls to iax2.conf that provide: qualifysmoothing = [yes/no]   ; use an average of the last two PONG results to reduce falsly detected LAGGED hosts qualifyfreqok = [ms]          ; how frequently to ping the peer when everything seems to be ok, in milliseconds qualifyfreqnotok = [ms]       ; how frequently to ping the peer when it's either LAGGED or UNAVAILABLE, in milliseconds Disclaimer on file. ****** ADDITIONAL INFORMATION ****** qualifyfreqok and qualifyfreqnotok simply expose the existing DEFAULT_FREQ_OK and DEFAULT_FREQ_NOTOK to user configuration. qualifysmooting is a rudimentary two-sample smoothing mechanism and really should be implemented as a [# samples in averaging window] to have the most value, however averaging the last two samples is sufficient for my purposes at the moment.
Comments:	By: kb1_kanobe2 (kb1_kanobe2) 2005-05-09 22:58:00 Whoops - beware there is a slight bug when setting the default values of qualifyfreqok and qualifyfreqnotok when these directives are not specified in the configuration file at all. They are used uninitialised, rather than set to DEFAULT_FREQ_OK and DEFAULT_FREQ_NOTOK respectively. I will upload a replacement patch tomorrow. By: Kevin P. Fleming (kpfleming) 2005-05-14 23:30:09 Do you have a replacement patch? By: kb1_kanobe2 (kb1_kanobe2) 2005-05-26 02:28:41 I've updated the attached patch to apply against CVS-HEAD 25may05 and to include the correct handling of default values. By: Michael Jerris (mikej) 2005-06-23 06:29:32 does this still apply cleanly? By: Kevin P. Fleming (kpfleming) 2005-06-23 22:00:30 The patch contains an unrelated reversal of some jitterbuffer changes. Also, iax.conf.sample will need to be updated to list and describe these new options (along with their default values). By: kb1_kanobe2 (kb1_kanobe2) 2005-06-24 10:49:01 Oops, looks like that 2am update to the original patch was a little off - sorry about that. I will work on updating it against Head this coming week. By: Olle Johansson (oej) 2005-07-18 14:41:17 Gentle reminder from housekeeping - any updates? By: kb1_kanobe2 (kb1_kanobe2) 2005-08-05 05:24:15 Sorry for the delay. Please review this replacement patch, relative to cvs-head of 2005-08-05 08:15:07. It should be clean and function correctly, at last. By: Kevin P. Fleming (kpfleming) 2005-08-23 13:10:10 Committed to CVS HEAD with mods (including a bug fix you didn't catch in the existing code <G>). Thanks! By: Digium Subversion (svnbot) 2008-01-15 15:45:11.000-0600 Repository: asterisk Revision: 6385 U   trunk/channels/chan_iax2.c ------------------------------------------------------------------------ r6385 | kpfleming | 2008-01-15 15:45:11 -0600 (Tue, 15 Jan 2008) | 2 lines allow more adjustability in peer qualification system (issue ASTERISK-4092 with mods) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6385