[Home]

Summary:ASTERISK-04090: [patch] add TOUCH_FORMAT channel var for OTR
Reporter:drmac (drmac)Labels:
Date Opened:2005-05-05 22:14:37Date Closed:2008-01-15 15:34:58.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_features
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) touch_format.patch.txt
Description:patch adds support to res_features.c to support different file formats using the channel var TOUCH_FORMAT.

patch also adds docs to README.variables

patch doesn't do this but it should be noted somewhere in the docs that OTR will "honor" the two channel variables used by Monitor(): MONITOR_EXEC and MONITOR_EXEC_ARGS

technically OTR doesn't care about the MONITOR_ variables; res_monitor looks for them; but still, I didn't know until I tried.

****** ADDITIONAL INFORMATION ******

Disclaimer on file
mboehm@cytelcom.com
Comments:By: Kevin P. Fleming (kpfleming) 2005-05-15 00:54:46

I'm OK with this going in, as long as we rename the variable to TOUCH_MONITOR_FORMAT or something similar... TOUCH_FORMAT just doesn't seem to be obviously linked to the TOUCH_MONITOR feature.

Are you OK with that change? If so, I'll get this in.
By: drmac (drmac) 2005-05-15 19:48:00

sounds good.
By: Kevin P. Fleming (kpfleming) 2005-05-15 20:38:07

Committed to CVS HEAD with variable name change, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:34:58.000-0600

Repository: asterisk
Revision: 5693

U   trunk/doc/README.variables
U   trunk/res/res_features.c

------------------------------------------------------------------------
r5693 | kpfleming | 2008-01-15 15:34:58 -0600 (Tue, 15 Jan 2008) | 2 lines

add ability to control output format for one-touch-record feature (bug ASTERISK-4090)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5693