[Home]

Summary:ASTERISK-04072: [patch] Volume Control
Reporter:Anthony Minessale (anthm)Labels:
Date Opened:2005-05-04 14:31:45Date Closed:2008-01-15 15:47:10.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) meetme_volume_rev1.diff
( 1) meetme_volume.diff
Description:This patch lets one control the volume of ones voice by pressing * followed by a series of 7's and 9's for up and down until you press 8 to accept and return to normal operation.

Brought to you by djMax at www.artsalliancelabs.com



****** ADDITIONAL INFORMATION ******

It could use some voice prompts but i don't have any.

Disclaimer On File
anthmct@yahoo.com
Comments:By: Olle Johansson (oej) 2005-05-04 14:35:18

Cool!
By: Mark Spencer (markster) 2005-05-04 14:57:58

Generally looks good only you never seem to use the "vf" calculation...
By: Anthony Minessale (anthm) 2005-05-04 15:31:37

you know, that was a typo cos i meant to use powers of 2 but single digits seems to work so i'll change it to do it that way.

I also forgot to skip 1 cos */ 1 doesnt really help much.
By: Olle Johansson (oej) 2005-06-05 17:08:33

"Brought to you by djMax at www.artsalliancelabs.com" - does this mean they own the code and needs to disclaim it?

Where are we with this patch? Is the rev1 approved?

/Housekeeping
By: Anthony Minessale (anthm) 2005-06-06 08:34:41

it's disclimed, it's owned by me they just funded the development.
By: Clod Patry (junky) 2005-06-06 11:26:23

When pressing 7 or 9, i've this:
Jun  6 12:22:40 WARNING[23207]: codec_gsm.c:148 gsmtolin_framein: Huh?  A GSM frame that isn't a multiple of 33 or 65 bytes long from (null) (320)?
Jun  6 12:22:40 WARNING[23207]: codec_gsm.c:148 gsmtolin_framein: Huh?  A GSM frame that isn't a multiple of 33 or 65 bytes long from (null) (320)?
Jun  6 12:22:40 WARNING[23207]: codec_gsm.c:148 gsmtolin_framein: Huh?  A GSM frame that isn't a multiple of 33 or 65 bytes long from (null) (320)?
Jun  6 12:22:40 WARNING[23207]: codec_gsm.c:148 gsmtolin_framein: Huh?  A GSM frame that isn't a multiple of 33 or 65 bytes long from (null) (320)?
By: Clod Patry (junky) 2005-06-23 23:02:57

anthm: what could be this problem exactly?
A problem on my side or a another problem?
By: Anthony Minessale (anthm) 2005-06-24 07:51:30

I dont know, did you try it many ways? i've never had that problem.
By: Michael Jerris (mikej) 2005-07-12 18:02:38

Do we need any prompts for this??? I can't think of where you would play them, but the secret squirl feature thing is a bit weird too... Thoughts?
By: Clod Patry (junky) 2005-07-12 23:20:49

there's no new prompts associated with that patch.
By: Michael Jerris (mikej) 2005-07-13 08:38:06

I know there are no prompts necessary for the patch, I was thinking if it was weird to not tell the users "somwhere" via prompt how to do it...either way..
By: Clod Patry (junky) 2005-07-20 00:08:51

i've re-tried that one, same loop i was getting before.
anthm: that's the way i've tried:

ive called meetme,
i press *, so i've got this in CLI:
   -- Playing 'conf-usermenu' (language 'en')
Jul 20 00:41:51 WARNING[20306]: codec_gsm.c:153 gsmtolin_framein: Huh?  A GSM frame that isn't a multiple of 33 or 65 bytes long from (null) (320)?
Jul 20 00:41:51 WARNING[20306]: codec_gsm.c:153 gsmtolin_framein: Huh?  A GSM frame that isn't a multiple of 33 or 65 bytes long from (null) (320)?
Jul 20 00:41:51 WARNING[20306]: codec_gsm.c:153 gsmtolin_framein: Huh?  A GSM frame that isn't a multiple of 33 or 65 bytes long from (null) (320)?
[... until i hangup ...]
Jul 20 00:41:52 WARNING[20306]: codec_gsm.c:153 gsmtolin_framein: Huh?  A GSM frame that isn't a multiple of 33 or 65 bytes long from (null) (320)?
   -- Hungup 'Zap/pseudo-760849683'
 == Spawn extension (test_sip, 2000, 1) exited non-zero on 'SIP/12-6276'

So any idea how could i fix the problem here to use that patch?
By: Michael Jerris (mikej) 2005-07-25 22:35:05

is the issue only with gsm?  is it still an issue?
By: Anthony Minessale (anthm) 2005-07-26 09:24:26

Junky told me he was mistaken , he gets the issue even without the patch.
By: Clod Patry (junky) 2005-07-26 10:04:27

anthm: error, only when pressing, 7 or 9.

you remember i had to add a ast_stopstream(chan);
By: Anthony Minessale (anthm) 2005-07-26 11:20:53

yah that was it, you need to call a stopstream after playing menu stuff cos a digit cancells the file and leaves it's readformat the same as the file it last played. *hint* there are a bunch of these in meetme I think.
By: Michael Jerris (mikej) 2005-08-24 02:11:49

junky, can you create a patch to add the ast_stopstream's where appropriate?
By: Kevin P. Fleming (kpfleming) 2005-09-06 19:58:28

I'm reworking this patch to use Zap-based gain adjustment so that it will actually work with Zap channels... stay tuned for the CVS commit.
By: Kevin P. Fleming (kpfleming) 2005-09-06 21:30:16

Committed a modified version to CVS HEAD that will support Zap channels in the conference as well. Thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:47:09.000-0600

Repository: asterisk
Revision: 6519

U   trunk/apps/app_chanspy.c
U   trunk/apps/app_meetme.c
U   trunk/channels/chan_iax2.c
U   trunk/channels/chan_zap.c
U   trunk/include/asterisk/frame.h

------------------------------------------------------------------------
r6519 | kpfleming | 2008-01-15 15:47:09 -0600 (Tue, 15 Jan 2008) | 5 lines

add new channel option (via ast_channel_setoption()) to let channel drivers adjust txgain/rxgain if they are able (only Zap channels at this time)
modify app_chanspy to use new gain option
reformat app_chanspy to match coding guidelines
add user-controlled volume adjustment to app_meetme (issue ASTERISK-4072, heavily modified to actually work on Zap channels)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6519
By: Digium Subversion (svnbot) 2008-01-15 15:47:10.000-0600

Repository: asterisk
Revision: 6520

U   trunk/apps/app_meetme.c

------------------------------------------------------------------------
r6520 | kpfleming | 2008-01-15 15:47:09 -0600 (Tue, 15 Jan 2008) | 2 lines

actually do issue ASTERISK-4072 right... it was supposed to adjust talk volume, not listen volume (sorry)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=6520