| Summary: | ASTERISK-04069: [patch] new jb - use defines for static adjustments | ||
| Reporter: | grolloj (grolloj) | Labels: | |
| Date Opened: | 2005-05-04 13:54:58 | Date Closed: | 2008-01-15 15:34:24.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_iax2 |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) jb_init_target.patch.txt ( 1) jb_param_defines.patch.txt | |
| Description: | This patch adds two defines for use in the new jb. These defines eliminate the use of last_voice_ms in a couple of places in the new jb. The patch provides some clarification to how values are used. More importantly, it will prevent the jitterbuffer from constantly adjusting its target size if the iLBC codec is used. I've observed that in this case, alternating 20ms and 40ms frames will be placed into the jitterbuffer. That causes the calculation (2 * jb->info.last_frame_ms) to constantly change. Using JB_TARGET_EXTRA instead prevents the extra space in the jb from changing every other frame. I originally included this fix as part of a larger patch in bug ASTERISK-3933965, but am breaking it out to make review easier. ****** ADDITIONAL INFORMATION ****** Disclaimer on file | ||
| Comments: | By: stevekstevek (stevekstevek) 2005-05-04 17:19:20 Mark: same notes apply here as in 4163. By: Mark Spencer (markster) 2005-05-09 09:50:37 Added to CVS, thanks! By: Russell Bryant (russell) 2005-05-10 00:07:40 new jb is not in 1.0 By: grolloj (grolloj) 2005-05-10 14:03:23 When the jb is reset, it should have it's target size defaulted to JB_TARGET_EXTRA so that 40ms (or whatever JB_TARGET_EXTRA is defined as) will be included in the jb from the beginning. This prevents the first frame from being returned at ts 0 and the next coming at ts 0 + ms + JB_TARGET_EXTRA. By: Mark Spencer (markster) 2005-05-14 19:58:14 Added mini-patch. By: Digium Subversion (svnbot) 2008-01-15 15:33:46.000-0600 Repository: asterisk Revision: 5610 U trunk/jitterbuf.c U trunk/jitterbuf.h ------------------------------------------------------------------------ r5610 | markster | 2008-01-15 15:33:46 -0600 (Tue, 15 Jan 2008) | 2 lines Jitter buffer improvements (bug ASTERISK-4069) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5610 By: Digium Subversion (svnbot) 2008-01-15 15:34:24.000-0600 Repository: asterisk Revision: 5655 U trunk/jitterbuf.c ------------------------------------------------------------------------ r5655 | markster | 2008-01-15 15:34:24 -0600 (Tue, 15 Jan 2008) | 2 lines Initialize target properly (bug ASTERISK-4069, take 2) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5655 | ||