[Home]

Summary:ASTERISK-04060: [patch] frame.c fix ast_frisolate for non-malloced data, comment out broken and unused functions
Reporter:Luigi Rizzo (rizzo)Labels:
Date Opened:2005-05-04 05:39:40Date Closed:2008-01-15 15:34:41.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) frame.c.diff-correct
Description:ast_frisolate() fails to handle frames with non-malloced data.
While it is never used in this way, this was a bug.

ast_fr_fdread() and ast_fr_fdwrite() are broken in that they did not
handle properly partial reads and writes, which are very likely
on TCP sockets. As they are never used, it is probably ok to comment
them out and postone the fix to when they are really necessary.
Comments:By: stevekstevek (stevekstevek) 2005-05-04 10:18:55

I think you forgot the patch, rizzo..

Also, you probably ought to mention a disclaimer, if you have one..
By: Kevin P. Fleming (kpfleming) 2005-05-04 12:17:37

That patch will not apply to CVS HEAD, and contains many things not related to this bug.
By: Luigi Rizzo (rizzo) 2005-05-04 12:49:37

uploaded the correct diff, frame.c.diff-correct

please disregard/delete the other one...
By: Michael Jerris (mikej) 2005-05-08 15:52:31

Rizzo, do you have a disclaimer??
By: Michael Jerris (mikej) 2005-05-08 15:52:58


By: Luigi Rizzo (rizzo) 2005-05-13 02:08:58

yes disclaimer on file.
life would be a lot easier if we could keep track of this on the
mantis database :) or at least provide a mandatory button on the
interface so we don't forget to mention yes or no :)
By: Kevin P. Fleming (kpfleming) 2005-05-15 01:41:18

Committed to CVS HEAD, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:34:41.000-0600

Repository: asterisk
Revision: 5674

U   trunk/frame.c

------------------------------------------------------------------------
r5674 | kpfleming | 2008-01-15 15:34:40 -0600 (Tue, 15 Jan 2008) | 2 lines

minor cleanups (bug ASTERISK-4060)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5674