Summary: | ASTERISK-04030: [patch] rtp.c: wrong error message on recvfrom error | ||
Reporter: | Luigi Rizzo (rizzo) | Labels: | |
Date Opened: | 2005-05-02 06:29:40 | Date Closed: | 2008-01-15 15:33:11.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) 4128-patch-rtp.c.patch.txt | |
Description: | recvfrom sometimes returns no data. This is perfectly normal being on a non-blocking socket. The code in rtp.c misinterprets this as "bad checksum" and prints an error message. The problem is in a couple of places probably due to cut&paste of sections of code - both in HEAD and 1.07 (so i believe it is also in the -stable branch). A trivial patch is attached. Applies to both modulo a few lines of offset. | ||
Comments: | By: Clod Patry (junky) 2005-05-02 06:38:25 Now, attach the same patch patch, but with name patch-rtp.txt and you'll be fine. :) Thanks. By: Kevin P. Fleming (kpfleming) 2005-05-04 00:35:03 junky: Now that the new version of Mantis is in place, there is no need for .txt extensions any longer, Mantis automatically makes all uploaded files appear as text/plain. By: Kevin P. Fleming (kpfleming) 2005-05-04 00:37:30 Committed to CVS HEAD, thanks! You didn't mention whether you have a disclaimer on file, although a trivial patch like this is safe anyway. Please remember to note that in the future when you upload patches. By: Digium Subversion (svnbot) 2008-01-15 15:33:11.000-0600 Repository: asterisk Revision: 5570 U trunk/rtp.c ------------------------------------------------------------------------ r5570 | kpfleming | 2008-01-15 15:33:11 -0600 (Tue, 15 Jan 2008) | 2 lines don't report EAGAIN as an error (bug ASTERISK-4030) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5570 |