| Summary: | ASTERISK-04020: [patch] pri_timer2idx usage incorrect in chan_zap.c | ||
| Reporter: | Abhishek Tiwari (abhi) | Labels: | |
| Date Opened: | 2005-04-29 22:55:22 | Date Closed: | 2008-01-15 15:32:45.000-0600 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) chan_zap.c.patch | |
| Description: | setting pritimes using pri_timer2idx, if an invalid timer id is used pri_timer2idx returns -1 while 0 is a valid id (N200). The if statement assumes return value 0 as error. patch for the same is attahed. ****** ADDITIONAL INFORMATION ****** disclamer on the file | ||
| Comments: | By: Kevin P. Fleming (kpfleming) 2005-05-01 14:41:17 Your patch was not actually against the current CVS version of chan_zap.c, but it was only offset by a few lines. It's been committed, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:32:45.000-0600 Repository: asterisk Revision: 5541 U trunk/channels/chan_zap.c ------------------------------------------------------------------------ r5541 | kpfleming | 2008-01-15 15:32:45 -0600 (Tue, 15 Jan 2008) | 2 lines properly check for error from pri_timer2idx (bug ASTERISK-4020) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5541 | ||