[Home]

Summary:ASTERISK-04010: [patch] Raise write() failure in my_zt_write from Debug to Warning
Reporter:kb1_kanobe2 (kb1_kanobe2)Labels:
Date Opened:2005-04-28 13:23:35Date Closed:2008-01-15 15:33:53.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) raisezt_writeLogSeverity.patch
Description:The attached trivial patch tweaks chan_zap.c to make it more apparent when there are problems pushing data into zaptel cards.

Disclaimer on file.

****** ADDITIONAL INFORMATION ******

I have some * boxes that are sporadically generating EAGAIN errors when writing to their t100p cards. This manifests itself as pops and clicks in the incoming audio and, if the calls are VoIP somewhere and a jitter buffer/PLC is not in use then the artifacts tend to be incorrectly attributed to network related problems. By raising this to a WARNING it more correctly represents the risk of audio corruption implied by the write() problem.

If I'd noticed these debugs going by amidst all the IAX packet scheduler debug on my systems I would have saved quite a few hours of fruitless network debugging.

:-)
Comments:By: Kevin P. Fleming (kpfleming) 2005-04-29 10:34:33

Committed to CVS, thanks!

By: Russell Bryant (russell) 2005-05-10 00:22:11

I have reverted this patch.

According to Mark, this is absolutely not a warning.  It is to be expected if there is jitter on the network, and can also happen when receiving DTMF.  It is NOT any kind of zaptel error.

By: Digium Subversion (svnbot) 2008-01-15 15:32:36.000-0600

Repository: asterisk
Revision: 5531

U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r5531 | kpfleming | 2008-01-15 15:32:35 -0600 (Tue, 15 Jan 2008) | 2 lines

make write() failures on Zap channels more prominent than 'debug' messages (bug ASTERISK-4010)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5531

By: Digium Subversion (svnbot) 2008-01-15 15:33:53.000-0600

Repository: asterisk
Revision: 5618

U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r5618 | russell | 2008-01-15 15:33:53 -0600 (Tue, 15 Jan 2008) | 2 lines

revert this patch ... THIS IS NORMAL OPERATION, see the bugnotes for details (bug ASTERISK-4010)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5618