[Home]

Summary:ASTERISK-03906: [patch] WaitExten option for Music on Hold
Reporter:Russell Bryant (russell)Labels:
Date Opened:2005-04-11 03:14:01Date Closed:2008-01-15 15:31:40.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) backgroundmoh.rev4.txt
Description:This patch adds an option to WaitExten to play music on hold to the caller while waiting for an extension.

*CLI> show application WaitExten

 -= Info about application 'WaitExten' =-

[Synopsis]:
Waits for an extension to be entered

[Description]:
 WaitExten([seconds][|options]): Waits for the user to enter a new extension for the
specified number of seconds, then returns 0. Seconds can be passed with
fractions of a seconds (eg: 1.5 = 1.5 seconds) or if unspecified the
default extension timeout will be used.
 Options:
   'm[(x)]' - Provide music on hold to the caller while waiting for an extension.
              Optionally, specify the class for music on hold within parenthesis.


This patch also removes the full word options "skip" and "noanswer" from the Background application and replaces them with single letter options "s" and "n".  This change is backwards compatible at this time since none of the other letters in those words are used for options.  However, a note for UPGRADE.txt has been included since we may want to use these letters in the future.

Both WaitExten and Background have been updated to use the new args parsing API.


****** ADDITIONAL INFORMATION ******

disclaimer is on file

russelb@clemson.edu
Comments:By: Brian West (bkw918) 2005-04-11 11:48:37

Might I ask what good this is?  I could see it confusing the hell out of someone. (just doing my objective part here :P  )

/b

By: Russell Bryant (russell) 2005-04-11 12:39:30

Well, I couldn't sleep last night, so I was helping some people in #asterisk.  Someone asked me how he could play MusicOnHold to the caller while waiting for them to press a digit.  

My First thought was StartMusicOnHold, WaitExten, and StopMusicOnHold, but that is kind of dirty.

What is confusing about it?

By: Russell Bryant (russell) 2005-04-11 12:56:48

What do you think would be a less confusing way to accomplish this?

An option to WaitExten?  MusicOnHold?

A new app, WaitExtenMOH?

edited on: 04-11-05 19:21

By: Russell Bryant (russell) 2005-04-12 09:22:59

rev1 has been uploaded ...

Instead of this being an option to Background, I have implemented it as a new application to be less confusing.

By: Russell Bryant (russell) 2005-04-12 12:47:46

rev2 - fixed some options parsing stuff

By: Leif Madsen (lmadsen) 2005-04-12 13:04:20

The first thing I thought of was have it as an option to WaitExten. You're doing the same major function, but just adding a twist to it (like adding a clock). I like the idea, just don't think it requires a separate app.

By: Russell Bryant (russell) 2005-04-12 13:36:47

rev3!  now an option to WaitExten

By: Russell Bryant (russell) 2005-04-13 01:22:17

coming soon ... rev4, using the args parsing API instead of my own ...

By: Russell Bryant (russell) 2005-04-13 04:50:38

rev4 has been uploaded with the help of my insomnia.

Both WaitExten and Background are now using the args parsing API.

By: twisted (twisted) 2005-04-13 17:19:52

I like this idea..  Seems that this would be useful in situations either to:

a) mask the option to dial an extension
b) provide music to callers while waiting on an extension to be dialed.

By: Mark Spencer (markster) 2005-04-15 00:56:11

Added to CVS, thanks!

By: Russell Bryant (russell) 2005-04-15 02:07:52

not included in 1.0  :)

By: Digium Subversion (svnbot) 2008-01-15 15:31:40.000-0600

Repository: asterisk
Revision: 5469

U   trunk/pbx.c

------------------------------------------------------------------------
r5469 | markster | 2008-01-15 15:31:40 -0600 (Tue, 15 Jan 2008) | 2 lines

Add MusicOnHold to waitexten, update Background to use newstyle options (bug ASTERISK-3906)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5469