[Home]

Summary:ASTERISK-03893: [patch] SAY DATETIME (SayUnixtime) support for AGI
Reporter:Matthew Nicholson (mnicholson)Labels:
Date Opened:2005-04-07 18:54:53Date Closed:2008-01-15 15:31:21.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_agi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) agi_say_datetime2.diff.txt
Description:This patch adds support equivlant to the SayUnixtime app to AGI via the SAY DATETIME command.

****** ADDITIONAL INFORMATION ******

Disclaimer on file.  Patch attached.
Comments:By: Matthew Nicholson (mnicholson) 2005-04-07 19:00:01

agi_say_datetime2.diff.txt fixes missing ' ' in default format.
By: Tilghman Lesher (tilghman) 2005-04-08 16:27:18

Couple suggestions:

1)  Why not use format "Q" as your default and make the necessary changes to language in say.c, instead of hardcoding specific language variants in the AGI?

2)  Because format can legitimately have spaces, I would suggest that you make it the last argument, and rejoin the multiple arguments that may result.
By: Matthew Nicholson (mnicholson) 2005-04-08 16:45:41

I do not understand your first point.  As for my choice for the default string, it came from the SayUnixtime application, other wise I would have just let say_date_with_format or what ever choose the default.

To your second point.  The format will have to be quoted so that AGI sees it as one option.  Just as the verbose command does it.  They are ordered the way they are so that the least used options can be left off.
By: Tilghman Lesher (tilghman) 2005-04-08 17:02:00

Oh, you're right.  We should probably come up with a reasonable default in say.c, instead of in SayUnixtime, so the language-specific formats are concentrated in one place.
By: Mark Spencer (markster) 2005-04-10 22:32:04

Added to CVS, thanks!
By: Russell Bryant (russell) 2005-04-10 22:39:28

not inlcuded in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:31:21.000-0600

Repository: asterisk
Revision: 5446

U   trunk/res/res_agi.c

------------------------------------------------------------------------
r5446 | markster | 2008-01-15 15:31:20 -0600 (Tue, 15 Jan 2008) | 2 lines

Add datetime to AGI (bug ASTERISK-3893)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5446