[Home]

Summary:ASTERISK-03886: queues lack distinctive ring support
Reporter:ldm (ldm)Labels:
Date Opened:2005-04-07 10:20:52Date Closed:2011-06-07 14:04:58
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk_queue_distinctive_ring.txt
Description:This does not work:

exten => 2131,1,SetVar(ALERT_INFO=<Internal>)
exten => 2131,2,Queue(standard|r)

The ALERT_INFO is discarded and no distinctive ring is sent to SIP agents.

****** ADDITIONAL INFORMATION ******

Patch included
Comments:By: Brian West (bkw918) 2005-04-07 10:41:05

Thats because you sett _ALERT_INFO and not ALERT_INFO.

This is not a bug.

/b
By: Brian West (bkw918) 2005-04-07 10:41:33

This is not a bug you must preceed the var with an underscore if you wish the other side of the call to get the var.  

/b
By: ldm (ldm) 2005-04-07 11:21:22

The following does nothing:

exten => 2131,1,SetVar(_ALERT_INFO=<Internal>)
exten => 2131,2,Queue(standard|r)

Adding an underscore to ALERT_INFO does _not_ pass the ALERT_INFO to SIP clients.

Whereas with my patch simply setting ALERT_INFO works.

What did you mean by closing the bug? It's not really a bug anyway but an enhancement request.
By: Brian West (bkw918) 2005-04-07 11:51:58

try adding a double __  The var is either there or it isn't.  If you add a double undersore it will do infinate inheritance.  While a single _ is just one single ineheritance.

This is still not a bug because the channel should have the var on it no matter what.  but then again you didn't paste your configs.

/b

edited on: 04-07-05 11:52
By: Brian West (bkw918) 2005-04-07 11:53:52

This functionality is already there that is why I closed your bug... you shoudln't have to do anythign to add or act on the alert_info var in app_queue if the channel already has it.

/b
By: Brian West (bkw918) 2005-04-07 12:00:16

I just tested this with member => SIP/something

works fine.

/b
By: Brian West (bkw918) 2005-04-07 12:01:12

-- Executing SetVar("SIP/16-ee77", "_ALERT_INFO=<internal>") in new stack
   -- Executing Queue("SIP/16-ee77", "default|r") in new stack
   -- Called SIP/11hannel SIP/11
   -- SIP/11-7c0b is ringingP/11
asterisk*CLI> show channel SIP/11-7c0b
-- General --
          Name: SIP/11-7c0b
          Type: SIP
      UniqueID: 1112891803.58
     Caller ID: 16
Caller ID Name: Brian's Phone
   DNID Digits: (N/A)
         State: Ringing (5)
         Rings: 0
  NativeFormat: 4
   WriteFormat: 4
    ReadFormat: 4
1st File Descriptor: 30
     Frames in: 1
    Frames out: 0
Time to Hangup: 0
  Elapsed Time: N/A
 Direct Bridge: <none>
Indirect Bridge: <none>
--   PBX   --
       Context: default
     Extension:
      Priority: 1
    Call Group: 0
  Pickup Group: 0
   Application: AppQueue
          Data: (Outgoing Line)
   Blocking in: ast_waitfor_nandfds
     Variables:
ALERT_INFO=<internal>
SIPCALLID=417754276b68fd1a33e9d16007ca7cb6@65.38.28.146
By: ldm (ldm) 2005-04-07 12:01:12

A double underscore STILL does not send anything to the SIP phones.

app_queue does not inherit any variable: check the source.
By: Brian West (bkw918) 2005-04-07 12:02:07

Its not app_Queues job.. its the channel.  If you're using chan_agent then that might be the problem.  It might be smashing them. But I just tested this with SIP/ members.  the app is not responsible for any variable inheritance.

/b

edited on: 04-07-05 12:03
By: ldm (ldm) 2005-04-07 12:02:26

Hum, are you testing this with CVS/HEAD?

On 1.0.7 is does nothing...
By: ldm (ldm) 2005-04-07 12:03:47

Was this underscore feature added in the dev branch?
By: Brian West (bkw918) 2005-04-07 12:05:56

CVS-HEAD here.. You marked this as a bug in CVS-head on your report.

/b
By: ldm (ldm) 2005-04-07 12:07:01

my mistake, I'm using debian's 1.0.7
By: Brian West (bkw918) 2005-04-07 12:13:09

Updated the bug .
By: Mark Spencer (markster) 2005-04-11 00:59:33

This will not likely be fixed in stable.  Can you confirm that setting __ALERT_INFO works properly in CVS head?  Thanks!
By: ldm (ldm) 2005-04-11 02:17:54

markster, can you confirm that my patch is harmless enough that I can use it in production until CVS comes of age?
By: Clod Patry (junky) 2005-04-11 11:41:12

ldm: could you just answer, if that works fine with HEAD?
patches here are for HEAD, not stable.

drumkilla decides if that goes in stable branch or not.
By: Kevin P. Fleming (kpfleming) 2005-04-13 00:37:58

That patch looks safe to apply to stable, it's only replicating the same functionality that app_dial already has.
By: Kevin P. Fleming (kpfleming) 2005-04-13 00:38:25

ldm, do you have a disclaimer on file?
By: ldm (ldm) 2005-04-14 02:02:29

(sorry for the late answer)

Yes, I do have disclaimer on file in the name of Louis-David Mitterrand.

Thanks,

PS: I didn't have the opportunity to test __ALERT_INFO in HEAD but bkw did and he says it works.
By: Kevin P. Fleming (kpfleming) 2005-04-20 11:50:57

Is anyone _really_ opposed to this going into stable? It's not a new option, or even really a new feature, it's just making an existing feature act consistently across different dialing methods.

Russell, what's your opinion?
By: Russell Bryant (russell) 2005-05-30 23:27:56

added to 1.0.  It will be included in 1.0.8

Thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:36:28.000-0600

Repository: asterisk
Revision: 5795

U   branches/v1-0/apps/app_queue.c

------------------------------------------------------------------------
r5795 | russell | 2008-01-15 15:36:28 -0600 (Tue, 15 Jan 2008) | 2 lines

fix distinctive ring for queue members (bug ASTERISK-3886)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5795