| Summary: | ASTERISK-03879: [patch] MGCP *70 callwaiting disable does not reenable on hu | ||
| Reporter: | duanecox (duanecox) | Labels: | |
| Date Opened: | 2005-04-06 14:03:21 | Date Closed: | 2008-01-15 15:39:35.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) mgcp_callwaiting-6.patch ( 1) 3971HeadCommit.txt ( 2) cvs-stable_chan_mgpc.c_callwaiting.patch ( 3) mgcp-20050601-2325-stable.diff | |
| Description: | MGCP has *70 callwaiting disable that sets callwaiting=0 *70 is supposed to be per call callwaiting diable, and reenable on hang up. Currently asterisk does not reenable callwaiting on hangup. The only way to reenable callwaiting is to reload asterisk or reload mgcp; both solutions would rebuild the endpoint and enable callwaiting. This patch sets a new variable 'hascallwaiting' and uses this to determine if call waiting should be reenabled for the endpoint on hang up. tested here and works; suspect markster may modify patch to eliminate new variable... ****** ADDITIONAL INFORMATION ****** disclaimer on file | ||
| Comments: | By: Mark Spencer (markster) 2005-04-11 00:57:09 Added to CVS with slight mods (bug ASTERISK-3879), thanks! By: Jason Parker (jparker) 2005-06-02 01:26:24 Added patch for v1-0. Disclaimer on file under A.K.A. North Antara. By: Russell Bryant (russell) 2005-06-02 09:41:45 Thanks for the patch! However, it's not going to compile. ;) By: duanecox (duanecox) 2005-06-02 12:27:05 uploaded correct -stable patch, included mark's logging mods i overlooked in original -head patch. this syncs call-waiting -head fix with -stable By: Jason Parker (jparker) 2005-06-02 17:32:33 I was close at least... Besides the formatting in hunk 2 and 4 (it technically worked, just tabbed over wrong), and the whole e->hascallwaiting = callwaiting thing... It was midnight, what can you expect? :p Can't say I didn't try. :) By: duanecox (duanecox) 2005-06-02 21:17:46 it's great to see others contributing to the MGCP development, seems SIP is predominate around here. By: Russell Bryant (russell) 2005-06-24 18:22:25 fixed in 1.0, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:31:24.000-0600 Repository: asterisk Revision: 5450 U trunk/channels/chan_mgcp.c ------------------------------------------------------------------------ r5450 | markster | 2008-01-15 15:31:23 -0600 (Tue, 15 Jan 2008) | 2 lines Fix MGCP call waiting (bug ASTERISK-3879, with mods) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5450 By: Digium Subversion (svnbot) 2008-01-15 15:39:35.000-0600 Repository: asterisk Revision: 6006 U branches/v1-0/CHANGES U branches/v1-0/channels/chan_mgcp.c ------------------------------------------------------------------------ r6006 | russell | 2008-01-15 15:39:35 -0600 (Tue, 15 Jan 2008) | 2 lines after a *70, re-enable call waiting on hangup (bug ASTERISK-3879) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6006 | ||