[Home]

Summary:ASTERISK-03870: [patch] mgcp amaflags are not passed to cdr
Reporter:duanecox (duanecox)Labels:
Date Opened:2005-04-05 12:07:22Date Closed:2008-01-15 15:31:03.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) mgcp_amaflags-1.patch
( 1) mgcp.conf.sample-1.patch
Description:chan_mgcp.c missing amaflags when building mgcp gateways, therefor amaflags are not passed to cdr app.

tested here, before patch, amaflags always default to DOCUMENTATION.  after patch, amaflags are set appropriately as per mgcp.conf

amaflags = {billing,documentation,omit}

modified mgcp.conf.sample to reflect options.

****** ADDITIONAL INFORMATION ******

disclaimer on file
Comments:By: Clod Patry (junky) 2005-04-05 12:11:45

Try to attach your patch as a .txt extension.
Thanks
By: duanecox (duanecox) 2005-04-05 12:26:48

patches are unix based carriage returns, convert to DOS??
By: Clod Patry (junky) 2005-04-05 14:36:45

When you make your patch, just: cvs diff -u file > blah.diff.txt
By: Kevin P. Fleming (kpfleming) 2005-04-05 16:45:27

Yeah, the current version of Mantis doesn't always mark attachments as text/plain, so if they don't have a .txt extension they are hard to view in the browser. The update we are testing will always use text/plain, so that will no longer be necessary.
By: Kevin P. Fleming (kpfleming) 2005-04-05 16:48:00

Committed to CVS, thanks!
By: Russell Bryant (russell) 2005-04-06 11:47:10

fixed in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:30:54.000-0600

Repository: asterisk
Revision: 5414

U   trunk/channels/chan_mgcp.c
U   trunk/configs/mgcp.conf.sample

------------------------------------------------------------------------
r5414 | kpfleming | 2008-01-15 15:30:53 -0600 (Tue, 15 Jan 2008) | 2 lines

ensure that MGCP AMA flags are passed into CDR (bug ASTERISK-3870)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5414
By: Digium Subversion (svnbot) 2008-01-15 15:31:03.000-0600

Repository: asterisk
Revision: 5425

U   branches/v1-0/channels/chan_mgcp.c

------------------------------------------------------------------------
r5425 | russell | 2008-01-15 15:31:02 -0600 (Tue, 15 Jan 2008) | 2 lines

correctly set amaflags (bug ASTERISK-3870)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5425