[Home]

Summary:ASTERISK-03856: [patch] ast_say_digit_str skips minus
Reporter:Anthony Minessale (anthm)Labels:
Date Opened:2005-04-04 09:51:21Date Closed:2008-01-15 15:30:37.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) say.c.diff
Description:ast_say_digit_str ignores negative numbers and reads them as positive. this patch lets it say "minus one" when it is fed -1

****** ADDITIONAL INFORMATION ******

Disclaimer on file.
anthmct@yahoo.com
Comments:By: Michael Jerris (mikej) 2005-04-04 10:23:36

should we be saying "minus" or "negative"
By: Kevin P. Fleming (kpfleming) 2005-04-04 11:18:05

I think 'minus' is acceptable, it's pretty common English usage. Also, we don't have a recording for 'negative' :-)

I've committed this to CVS; if we get complaints about not saying 'negative' the complainers can provide the new recording.

Thanks!
By: Russell Bryant (russell) 2005-04-05 01:42:30

fixed in 1.0 as well (had to add minus.gsm while I was at it)
By: Digium Subversion (svnbot) 2008-01-15 15:30:27.000-0600

Repository: asterisk
Revision: 5384

U   trunk/say.c

------------------------------------------------------------------------
r5384 | kpfleming | 2008-01-15 15:30:27 -0600 (Tue, 15 Jan 2008) | 2 lines

let ast_say_digit_str say 'minus' preceding negative numbers (bug ASTERISK-3856)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5384
By: Digium Subversion (svnbot) 2008-01-15 15:30:37.000-0600

Repository: asterisk
Revision: 5395

U   branches/v1-0/say.c

------------------------------------------------------------------------
r5395 | russell | 2008-01-15 15:30:37 -0600 (Tue, 15 Jan 2008) | 2 lines

say "minus" for negative numbers (bug ASTERISK-3856)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5395