| Summary: | ASTERISK-03849: *67 caller ID blocking on MGCP only works for first call | ||
| Reporter: | gkloepfer (gkloepfer) | Labels: | |
| Date Opened: | 2005-04-03 23:18:02 | Date Closed: | 2008-01-15 15:30:40.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) chan-mgcp-patch | |
| Description: | When using *67 to block Caller-ID on MGCP, it only works for the first call on a line. All subsequent attempts to use *67 returns reorder (congestion). Problem is that the caller ID blocking code was pulled from chan_zap, and chan_mgcp handles Caller ID blocking differently from chan_zap. There is no "hidecallerid" configuration option, and thus no stored initial value for p->hidecallerid set when entering the simple switch. Included fix initializes p->hidecallerid to "off" when entering the simple switch thread (mgcp_ss), and also removes the code for *82 since it is not applicable to MGCP. ****** ADDITIONAL INFORMATION ****** Bug appears to be in Release as of 2005-03-21 and was in the CVS source pulled on 2005-03-23. The fix discussed assumes that there is not an intent to support the "hidecallerid" config file option as implemented in chan_zap. If hidecallerid is going to be implemented, then the correct fix is to implement this option as it is in chan_zap (with a separate "initial" value for p->hidecallerid determined by the config file option). | ||
| Comments: | By: gkloepfer (gkloepfer) 2005-04-04 07:45:29 Forgot to mention that I do have a disclaimer on file. By: Mark Spencer (markster) 2005-04-04 09:21:35 Fixed in CVS head, but I did not remove the *82 option. By: Russell Bryant (russell) 2005-04-05 02:06:01 fixed in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:30:25.000-0600 Repository: asterisk Revision: 5382 U trunk/channels/chan_mgcp.c ------------------------------------------------------------------------ r5382 | markster | 2008-01-15 15:30:25 -0600 (Tue, 15 Jan 2008) | 2 lines Fix MGCP *67 to automatically reset callerid (bug ASTERISK-3849) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5382 By: Digium Subversion (svnbot) 2008-01-15 15:30:40.000-0600 Repository: asterisk Revision: 5398 U branches/v1-0/CHANGES U branches/v1-0/channels/chan_mgcp.c ------------------------------------------------------------------------ r5398 | russell | 2008-01-15 15:30:39 -0600 (Tue, 15 Jan 2008) | 2 lines fix *67 (bug ASTERISK-3849) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5398 | ||