| Summary: | ASTERISK-03842: [patch] split meetme into more functions | ||
| Reporter: | mochouinard (mochouinard) | Labels: | |
| Date Opened: | 2005-04-01 23:43:28.000-0600 | Date Closed: | 2011-06-07 14:04:40 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_meetme |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) app_meetme.c-restructure_rev2.txt ( 1) app_meetme.c-restructure_rev3.txt ( 2) app_meetme.c-restructure_rev4.txt ( 3) meetme.conf.sample | |
| Description: | This patch is just to make meetme more readable, Ive created functions from current code. More could be done. Also Ive used astyle -t to cleanup the style of the code also. ****** ADDITIONAL INFORMATION ****** Disclamed | ||
| Comments: | By: mochouinard (mochouinard) 2005-04-02 11:55:52.000-0600 here is alittle more cleanup. My main gold rightnow is to strip out conf_run. And also have 3408 in it. (so nearly everything will have being split in the right function. Oh and the function name, please propose whatever you like, Im not native english By: Tilghman Lesher (tilghman) 2005-04-02 12:20:14.000-0600 Some of the reformats you have in here are removing tab indentation and replacing tabs with spaces, which is different from the standard code style. Also, descriptions are intentionally NOT indented, to make it easier to check whether you've exceeded column 80, which is the natural end of line for text displays; that indentation also needs to be removed. By: mochouinard (mochouinard) 2005-04-02 12:43:38.000-0600 here is a updated formating. Should I upload the app_meetme.c in itself ? the patch is the same size as the application ;) By: Tilghman Lesher (tilghman) 2005-04-02 14:06:13.000-0600 You might want to upload both. Mark wants the diff, to apply to CVS, but the source file is naturally easier to read online. By: mochouinard (mochouinard) 2005-04-02 14:37:53.000-0600 rev4.txt isnt a patch, but the full app_meetme.c file with patch ASTERISK-333508, ASTERISK-379080 (fixed ofcourses) will be for a discution with other developper By: Michael Jerris (mikej) 2005-04-17 22:37:53 Does this patch, with the stuff from 0003408, 0003880 stripped out work? I think maybe it will be easier to get in at this point without adding 2 other stalled bugs to the mix. With this in it should be much easier to address the outstanding meetme bugs. By: mochouinard (mochouinard) 2005-05-14 19:42:09 replace by my new meetme app | ||