[Home]

Summary:ASTERISK-03841: [patch] fix all deadlocks in app_queue and chan_agent.
Reporter:Brian West (bkw918)Labels:
Date Opened:2005-04-01 16:32:08.000-0600Date Closed:2005-04-02 02:02:21.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) deadlock_fix_ref0.diff.txt
Description:This patch should correct any and all deadlocks in app_queue and chan_agent. ;)
Comments:By: Kevin P. Fleming (kpfleming) 2005-04-01 16:35:47.000-0600

You neglected to remove these files from the Makefiles, so Asterisk won't compile with this patch applied.

By: Brian West (bkw918) 2005-04-01 16:38:01.000-0600

Updated.

By: Kevin P. Fleming (kpfleming) 2005-04-01 16:39:21.000-0600

We cannot apply this patch without it being disclaimed.

By: Olle Johansson (oej) 2005-04-01 16:53:51.000-0600

I see that this patch does not really add anything, so legally I don't think a disclaimer is needed.

And indeed, it actually solves a lot of problems with the Queue system. I will consider a similar approach to chan_sip.

By: Brian West (bkw918) 2005-04-01 17:25:04.000-0600

I think we could apply the osip patch to chan_sip and turn it into chan_osip.c?  I think PTG said he would do it.

/b

By: brc007 (brc007) 2005-04-01 18:21:07.000-0600

What command do you use for that?

By: Kevin P. Fleming (kpfleming) 2005-04-01 19:17:28.000-0600

I'm sorry, I've applied this patch and I see no change in behavior :-)

By: Russell Bryant (russell) 2005-04-02 02:02:21.000-0600

added to to the super-secret stable branch!