[Home]

Summary:ASTERISK-03837: [patch] pbx_spool feof vs fgets EOF detection
Reporter:Matthew Nicholson (mnicholson)Labels:
Date Opened:2005-04-01 14:37:23.000-0600Date Closed:2008-01-15 15:30:06.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) pbx_spool3.diff.txt
Description:The fgets function returns NULL on error or at EOF and no characters have been read, there for it is unnecessary to check for eof then check the length of the string read.  We can just use fgets.  This patch does that.

****** ADDITIONAL INFORMATION ******

Disclaimer on file.
Comments:By: Matthew Nicholson (mnicholson) 2005-04-01 14:38:06.000-0600

Sorry, category should not be Gastman.
By: Kevin P. Fleming (kpfleming) 2005-04-01 15:38:02.000-0600

Committed to CVS, thanks!
By: Russell Bryant (russell) 2005-04-02 11:48:27.000-0600

fixed in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:29:59.000-0600

Repository: asterisk
Revision: 5351

U   trunk/pbx/pbx_spool.c

------------------------------------------------------------------------
r5351 | kpfleming | 2008-01-15 15:29:58 -0600 (Tue, 15 Jan 2008) | 2 lines

optimize file reading in pbx_spool (bug ASTERISK-3837)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5351
By: Digium Subversion (svnbot) 2008-01-15 15:30:06.000-0600

Repository: asterisk
Revision: 5359

U   branches/v1-0/pbx/pbx_spool.c

------------------------------------------------------------------------
r5359 | russell | 2008-01-15 15:30:05 -0600 (Tue, 15 Jan 2008) | 2 lines

remove duplicate checking (bug ASTERISK-3837)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5359